New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove . import from e2e test #78916
Conversation
timer_test.go seems necessary to be updated:
|
Thank you for your comment. The last commit should fix it. PTAL |
@mkimuram Thanks for updating. |
Squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating
/lgtm
@mkimuram Unfortunately this needs to be rebased. |
Thank you for notifying me the need for rebase. Rebased. PTAL |
/test pull-kubernetes-e2e-gce |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkimuram, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
2 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of: #77706
Special notes for your reviewer:
/sig testing
@oomichi
It seems that there are some . imports still remaining. Replaced with the below commands.
Does this PR introduce a user-facing change?: