Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kubelet can not delete orphaned pod directory when "/var/lib/kubelet/pods" directory symbolically links to another device's directory #79094

Merged
merged 1 commit into from Jun 19, 2019

Conversation

@gaorong
Copy link
Contributor

commented Jun 17, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
please see the related issue :)

Which issue(s) this PR fixes:

Fixes #79093

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix kubelet fail to delete orphaned pod directory when the kubelet's pods directory (default is "/var/lib/kubelet/pods") symbolically links to another disk device's directory
…root directory symbolically links to another device's directory
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

Hi @gaorong. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from jsafrane and saad-ali Jun 17, 2019
@jsafrane

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

I am not sure how Stat could fix check of directory like /var/lib/kubelet/pods/7867edd3-8136-11e9-87ea-0017fa007527.

Stat and Lstat on /var/lib/kubelet/pods/ should return the same result if /var/lib/kubelet is a symlink - it's pods directory that's being examined, not kubelet.

They would differ only if pods was a symlink.

@gaorong

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

They would differ only if pods was a symlink.

Yes, you are right, sorry for the misleading. I'll change all the descriptions.

@gaorong gaorong changed the title fix kubelet can not delete orphaned pod directory when the kubelet's root directory symbolically links to another device's directory fix kubelet can not delete orphaned pod directory when "/var/lib/kubelet/pods" directory symbolically links to another device's directory Jun 17, 2019
@jsafrane

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

/lgtm
/approve

@jsafrane

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaorong, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 18, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot

This comment has been minimized.

Copy link

commented Jun 18, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@gaorong

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage and removed needs-sig labels Jun 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit efa0431 into kubernetes:master Jun 19, 2019
23 checks passed
23 checks passed
cla/linuxfoundation gaorong authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@gaorong gaorong deleted the gaorong:fix-IsLikelyNotMountPoint branch Jun 19, 2019
k8s-ci-robot added a commit that referenced this pull request Jul 3, 2019
…4-up-release-1.13

Automated cherry pick of #79094: fix kubelet can not delete orphaned pod directory when "/var/lib/kubelet/pods" directory symbolically links to another device's directory
k8s-ci-robot added a commit that referenced this pull request Jul 3, 2019
…4-up-release-1.14

Automated cherry pick of #79094: fix kubelet can not delete orphaned pod directory when "/var/lib/kubelet/pods" directory symbolically links to another device's directory
k8s-ci-robot added a commit that referenced this pull request Jul 4, 2019
…4-up-release-1.15

Automated cherry pick of #79094: fix kubelet can not delete orphaned pod directory when "/var/lib/kubelet/pods" directory symbolically links to another device's directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.