Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add @SataQiu as a reviewer for kubeadm #79167

Closed
wants to merge 1 commit into from
Closed

kubeadm: add @SataQiu as a reviewer for kubeadm #79167

wants to merge 1 commit into from

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jun 19, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
I have been following, contributing and reviewing against kubeadm for a long time.
This adds myself as a reviewer to let me involve more.

My Sponsors: @neolit123 @rosti

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SataQiu
To complete the pull request process, please assign luxas
You can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 19, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Jun 19, 2019

/cc @neolit123 @rosti

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 19, 2019
@neolit123
Copy link
Member

/assign @timothysc

@SataQiu
Copy link
Member Author

SataQiu commented Jun 19, 2019

/test pull-kubernetes-integration

@neolit123 neolit123 mentioned this pull request Jun 20, 2019
Merged
@neolit123
Copy link
Member

making other updates to OWNER files.
see here:
#79218

moving the your addition there.
/close

@k8s-ci-robot
Copy link
Contributor

@neolit123: Closed this PR.

In response to this:

making other updates to OWNER files.
see here:
#79218

moving the your addition there.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ereslibre ereslibre Awaiting requested review from ereslibre

@timothysc timothysc Awaiting requested review from timothysc

@neolit123 neolit123 Awaiting requested review from neolit123

@rosti rosti Awaiting requested review from rosti

Assignees

@timothysc timothysc

Labels
area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SataQiu @k8s-ci-robot @neolit123 @timothysc