Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup feature gates for KubeletPluginsWatcher #79310

Conversation

@draveness
Copy link
Member

commented Jun 23, 2019

/kind cleanup

What this PR does / why we need it:

KubeletPluginsWatcher has already graduated to GA two releases ago, we could remove it in release 1.16

Which issue(s) this PR fixes:

ref: #79308

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove KubeletPluginsWatcher feature gates

/priority important-soon
/assign @vikaschoudhary16

Copy link
Contributor

left a comment

/lgtm

thanks for this clean up!

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2109c1a into kubernetes:master Jun 24, 2019
23 checks passed
23 checks passed
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@draveness draveness deleted the draveness:feature/cleanup-KubeletPluginsWatcher-feature-gates branch Jun 24, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
rfranzke added a commit to rfranzke/gardener-extensions that referenced this pull request Sep 19, 2019
The feature gate was already beta in 1.13 (least supported version of
Alicloud/Packet which were using it) and enabled by default, it
graduated to GA in 1.14. We never needed to explicitly enable it, we
just have to make sure that it's not disabled.

See kubernetes/kubernetes#79310
rfranzke added a commit to gardener/gardener-extensions that referenced this pull request Sep 19, 2019
The feature gate was already beta in 1.13 (least supported version of
Alicloud/Packet which were using it) and enabled by default, it
graduated to GA in 1.14. We never needed to explicitly enable it, we
just have to make sure that it's not disabled.

See kubernetes/kubernetes#79310
rfranzke added a commit to gardener/gardener-extensions that referenced this pull request Sep 19, 2019
The feature gate was already beta in 1.13 (least supported version of
Alicloud/Packet which were using it) and enabled by default, it
graduated to GA in 1.14. We never needed to explicitly enable it, we
just have to make sure that it's not disabled.

See kubernetes/kubernetes#79310
rfranzke added a commit to gardener/gardener-extensions that referenced this pull request Sep 20, 2019
The feature gate was already beta in 1.13 (least supported version of
Alicloud/Packet which were using it) and enabled by default, it
graduated to GA in 1.14. We never needed to explicitly enable it, we
just have to make sure that it's not disabled.

See kubernetes/kubernetes#79310
rfranzke added a commit to gardener/gardener-extensions that referenced this pull request Sep 20, 2019
The feature gate was already beta in 1.13 (least supported version of
Alicloud/Packet which were using it) and enabled by default, it
graduated to GA in 1.14. We never needed to explicitly enable it, we
just have to make sure that it's not disabled.

See kubernetes/kubernetes#79310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.