Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: Stop using //pkg/util/normalizer #79335

Merged
merged 1 commit into from
Jun 24, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/kubeadm/.import-restrictions
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"k8s.io/kubernetes/pkg/util/ipvs",
"k8s.io/kubernetes/pkg/util/metrics",
"k8s.io/kubernetes/pkg/util/node",
"k8s.io/kubernetes/pkg/util/normalizer",
"k8s.io/kubernetes/pkg/util/parsers",
"k8s.io/kubernetes/pkg/util/procfs",
"k8s.io/kubernetes/pkg/util/sysctl",
Expand Down
1 change: 0 additions & 1 deletion cmd/kubeadm/app/cmd/alpha/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ go_library(
"//cmd/kubeadm/app/util/apiclient:go_default_library",
"//cmd/kubeadm/app/util/config:go_default_library",
"//cmd/kubeadm/app/util/kubeconfig:go_default_library",
"//pkg/util/normalizer:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/util/duration:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/util/version:go_default_library",
"//vendor/github.com/lithammer/dedent:go_default_library",
Expand Down
7 changes: 3 additions & 4 deletions cmd/kubeadm/app/cmd/alpha/certs.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,10 @@ import (
kubeadmutil "k8s.io/kubernetes/cmd/kubeadm/app/util"
configutil "k8s.io/kubernetes/cmd/kubeadm/app/util/config"
kubeconfigutil "k8s.io/kubernetes/cmd/kubeadm/app/util/kubeconfig"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
genericCertRenewLongDesc = normalizer.LongDesc(`
genericCertRenewLongDesc = cmdutil.LongDesc(`
Renew the %s.

Renewals run unconditionally, regardless of certificate expiration date; extra attributes such as SANs will
Expand All @@ -55,12 +54,12 @@ var (
eventually re-distribute the renewed certificate in case the file is used elsewhere.
`)

allLongDesc = normalizer.LongDesc(`
allLongDesc = cmdutil.LongDesc(`
Renew all known certificates necessary to run the control plane. Renewals are run unconditionally, regardless
of expiration date. Renewals can also be run individually for more control.
`)

expirationLongDesc = normalizer.LongDesc(`
expirationLongDesc = cmdutil.LongDesc(`
Checks expiration for the certificates in the local PKI managed by kubeadm.
`)

Expand Down
7 changes: 3 additions & 4 deletions cmd/kubeadm/app/cmd/alpha/kubeconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,18 @@ import (
kubeconfigphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/kubeconfig"
kubeadmutil "k8s.io/kubernetes/cmd/kubeadm/app/util"
configutil "k8s.io/kubernetes/cmd/kubeadm/app/util/config"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
kubeconfigLongDesc = normalizer.LongDesc(`
kubeconfigLongDesc = cmdutil.LongDesc(`
Kubeconfig file utilities.
` + cmdutil.AlphaDisclaimer)

userKubeconfigLongDesc = normalizer.LongDesc(`
userKubeconfigLongDesc = cmdutil.LongDesc(`
Output a kubeconfig file for an additional user.
` + cmdutil.AlphaDisclaimer)

userKubeconfigExample = normalizer.Examples(`
userKubeconfigExample = cmdutil.Examples(`
# Output a kubeconfig file for an additional user named foo
kubeadm alpha kubeconfig user --client-name=foo
`)
Expand Down
9 changes: 4 additions & 5 deletions cmd/kubeadm/app/cmd/alpha/kubelet.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,26 +29,25 @@ import (
"k8s.io/kubernetes/cmd/kubeadm/app/preflight"
kubeadmutil "k8s.io/kubernetes/cmd/kubeadm/app/util"
kubeconfigutil "k8s.io/kubernetes/cmd/kubeadm/app/util/kubeconfig"
"k8s.io/kubernetes/pkg/util/normalizer"
utilsexec "k8s.io/utils/exec"
)

var (
kubeletConfigDownloadLongDesc = normalizer.LongDesc(`
kubeletConfigDownloadLongDesc = cmdutil.LongDesc(`
Download the kubelet configuration from a ConfigMap of the form "kubelet-config-1.X" in the cluster,
where X is the minor version of the kubelet. Either kubeadm autodetects the kubelet version by exec-ing
"kubelet --version" or respects the --kubelet-version parameter.
` + cmdutil.AlphaDisclaimer)

kubeletConfigDownloadExample = normalizer.Examples(fmt.Sprintf(`
kubeletConfigDownloadExample = cmdutil.Examples(fmt.Sprintf(`
# Download the kubelet configuration from the ConfigMap in the cluster. Autodetect the kubelet version.
kubeadm alpha phase kubelet config download

# Download the kubelet configuration from the ConfigMap in the cluster. Use a specific desired kubelet version.
kubeadm alpha phase kubelet config download --kubelet-version %s
`, constants.CurrentKubernetesVersion))

kubeletConfigEnableDynamicLongDesc = normalizer.LongDesc(`
kubeletConfigEnableDynamicLongDesc = cmdutil.LongDesc(`
Enable or update dynamic kubelet configuration for a Node, against the kubelet-config-1.X ConfigMap in the cluster,
where X is the minor version of the desired kubelet version.

Expand All @@ -57,7 +56,7 @@ var (

` + cmdutil.AlphaDisclaimer)

kubeletConfigEnableDynamicExample = normalizer.Examples(fmt.Sprintf(`
kubeletConfigEnableDynamicExample = cmdutil.Examples(fmt.Sprintf(`
# Enable dynamic kubelet configuration for a Node.
kubeadm alpha phase kubelet enable-dynamic-config --node-name node-1 --kubelet-version %s

Expand Down
10 changes: 4 additions & 6 deletions cmd/kubeadm/app/cmd/alpha/selfhosting.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ import (
"bufio"
"fmt"
"io"
"os"
"strings"
"time"

"github.com/pkg/errors"
"github.com/spf13/cobra"
Expand All @@ -38,21 +40,17 @@ import (
"k8s.io/kubernetes/cmd/kubeadm/app/util/apiclient"
configutil "k8s.io/kubernetes/cmd/kubeadm/app/util/config"
kubeconfigutil "k8s.io/kubernetes/cmd/kubeadm/app/util/kubeconfig"
"k8s.io/kubernetes/pkg/util/normalizer"

"os"
"time"
)

var (
selfhostingLongDesc = normalizer.LongDesc(`
selfhostingLongDesc = cmdutil.LongDesc(`
Convert static Pod files for control plane components into self-hosted DaemonSets configured via the Kubernetes API.

See the documentation for self-hosting limitations.

` + cmdutil.AlphaDisclaimer)

selfhostingExample = normalizer.Examples(`
selfhostingExample = cmdutil.Examples(`
# Convert a static Pod-hosted control plane into a self-hosted one.

kubeadm alpha phase self-hosting convert-from-staticpods
Expand Down
1 change: 0 additions & 1 deletion cmd/kubeadm/app/cmd/phases/init/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ go_library(
"//cmd/kubeadm/app/util/apiclient:go_default_library",
"//cmd/kubeadm/app/util/dryrun:go_default_library",
"//cmd/kubeadm/app/util/pkiutil:go_default_library",
"//pkg/util/normalizer:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library",
"//staging/src/k8s.io/client-go/kubernetes:go_default_library",
Expand Down
5 changes: 2 additions & 3 deletions cmd/kubeadm/app/cmd/phases/init/addons.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,15 @@ import (
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
dnsaddon "k8s.io/kubernetes/cmd/kubeadm/app/phases/addons/dns"
proxyaddon "k8s.io/kubernetes/cmd/kubeadm/app/phases/addons/proxy"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
coreDNSAddonLongDesc = normalizer.LongDesc(`
coreDNSAddonLongDesc = cmdutil.LongDesc(`
Install the CoreDNS addon components via the API server.
Please note that although the DNS server is deployed, it will not be scheduled until CNI is installed.
`)

kubeProxyAddonLongDesc = normalizer.LongDesc(`
kubeProxyAddonLongDesc = cmdutil.LongDesc(`
Install the kube-proxy addon components via the API server.
`)
)
Expand Down
6 changes: 3 additions & 3 deletions cmd/kubeadm/app/cmd/phases/init/bootstraptoken.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,21 @@ import (

"k8s.io/kubernetes/cmd/kubeadm/app/cmd/options"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow"
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
clusterinfophase "k8s.io/kubernetes/cmd/kubeadm/app/phases/bootstraptoken/clusterinfo"
nodebootstraptokenphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/bootstraptoken/node"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
bootstrapTokenLongDesc = normalizer.LongDesc(`
bootstrapTokenLongDesc = cmdutil.LongDesc(`
Bootstrap tokens are used for establishing bidirectional trust between a node joining
the cluster and a the control-plane node.

This command makes all the configurations required to make bootstrap tokens works
and then creates an initial token.
`)

bootstrapTokenExamples = normalizer.Examples(`
bootstrapTokenExamples = cmdutil.Examples(`
# Make all the bootstrap token configurations and create an initial token, functionally
# equivalent to what generated by kubeadm init.
kubeadm init phase bootstrap-token
Expand Down
5 changes: 2 additions & 3 deletions cmd/kubeadm/app/cmd/phases/init/certs.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,16 @@ import (
certsphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/certs"
kubeadmutil "k8s.io/kubernetes/cmd/kubeadm/app/util"
"k8s.io/kubernetes/cmd/kubeadm/app/util/pkiutil"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
saKeyLongDesc = fmt.Sprintf(normalizer.LongDesc(`
saKeyLongDesc = fmt.Sprintf(cmdutil.LongDesc(`
Generate the private key for signing service account tokens along with its public key, and save them into
%s and %s files.
If both files already exist, kubeadm skips the generation step and existing files will be used.
`+cmdutil.AlphaDisclaimer), kubeadmconstants.ServiceAccountPrivateKeyName, kubeadmconstants.ServiceAccountPublicKeyName)

genericLongDesc = normalizer.LongDesc(`
genericLongDesc = cmdutil.LongDesc(`
Generate the %[1]s, and save them into %[2]s.cert and %[2]s.key files.%[3]s

If both files already exist, kubeadm skips the generation step and existing files will be used.
Expand Down
3 changes: 1 addition & 2 deletions cmd/kubeadm/app/cmd/phases/init/controlplane.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,10 @@ import (
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
kubeadmconstants "k8s.io/kubernetes/cmd/kubeadm/app/constants"
"k8s.io/kubernetes/cmd/kubeadm/app/phases/controlplane"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
controlPlaneExample = normalizer.Examples(`
controlPlaneExample = cmdutil.Examples(`
# Generates all static Pod manifest files for control plane components,
# functionally equivalent to what is generated by kubeadm init.
kubeadm init phase control-plane all
Expand Down
3 changes: 1 addition & 2 deletions cmd/kubeadm/app/cmd/phases/init/etcd.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,10 @@ import (
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow"
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
etcdphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/etcd"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
etcdLocalExample = normalizer.Examples(`
etcdLocalExample = cmdutil.Examples(`
# Generates the static Pod manifest file for etcd, functionally
# equivalent to what is generated by kubeadm init.
kubeadm init phase etcd local
Expand Down
3 changes: 1 addition & 2 deletions cmd/kubeadm/app/cmd/phases/init/kubeconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
kubeadmconstants "k8s.io/kubernetes/cmd/kubeadm/app/constants"
kubeconfigphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/kubeconfig"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
Expand All @@ -42,7 +41,7 @@ var (
kubeadmconstants.KubeletKubeConfigFileName: {
name: "kubelet",
short: "Generate a kubeconfig file for the kubelet to use *only* for cluster bootstrapping purposes",
long: normalizer.LongDesc(`
long: cmdutil.LongDesc(`
Generate the kubeconfig file for the kubelet to use and save it to %s file.

Please note that this should *only* be used for cluster bootstrapping purposes. After your control plane is up,
Expand Down
4 changes: 2 additions & 2 deletions cmd/kubeadm/app/cmd/phases/init/kubelet.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ import (
"k8s.io/klog"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/options"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow"
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
kubeletphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/kubelet"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
kubeletStartPhaseExample = normalizer.Examples(`
kubeletStartPhaseExample = cmdutil.Examples(`
# Writes a dynamic environment file with kubelet flags from a InitConfiguration file.
kubeadm init phase kubelet-start --config config.yaml
`)
Expand Down
4 changes: 2 additions & 2 deletions cmd/kubeadm/app/cmd/phases/init/markcontrolplane.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ import (
"github.com/pkg/errors"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/options"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow"
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
markcontrolplanephase "k8s.io/kubernetes/cmd/kubeadm/app/phases/markcontrolplane"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
markControlPlaneExample = normalizer.Examples(`
markControlPlaneExample = cmdutil.Examples(`
# Applies control-plane label and taint to the current node, functionally equivalent to what executed by kubeadm init.
kubeadm init phase mark-control-plane --config config.yml

Expand Down
4 changes: 2 additions & 2 deletions cmd/kubeadm/app/cmd/phases/init/preflight.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ import (
"github.com/pkg/errors"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/options"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow"
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
"k8s.io/kubernetes/cmd/kubeadm/app/preflight"
"k8s.io/kubernetes/pkg/util/normalizer"
utilsexec "k8s.io/utils/exec"
)

var (
preflightExample = normalizer.Examples(`
preflightExample = cmdutil.Examples(`
# Run pre-flight checks for kubeadm init using a config file.
kubeadm init phase preflight --config kubeadm-config.yml
`)
Expand Down
9 changes: 4 additions & 5 deletions cmd/kubeadm/app/cmd/phases/init/uploadconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,28 +31,27 @@ import (
kubeletphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/kubelet"
patchnodephase "k8s.io/kubernetes/cmd/kubeadm/app/phases/patchnode"
"k8s.io/kubernetes/cmd/kubeadm/app/phases/uploadconfig"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var (
uploadKubeadmConfigLongDesc = fmt.Sprintf(normalizer.LongDesc(`
uploadKubeadmConfigLongDesc = fmt.Sprintf(cmdutil.LongDesc(`
Upload the kubeadm ClusterConfiguration to a ConfigMap called %s in the %s namespace.
This enables correct configuration of system components and a seamless user experience when upgrading.

Alternatively, you can use kubeadm config.
`), kubeadmconstants.KubeadmConfigConfigMap, metav1.NamespaceSystem)

uploadKubeadmConfigExample = normalizer.Examples(`
uploadKubeadmConfigExample = cmdutil.Examples(`
# upload the configuration of your cluster
kubeadm init phase upload-config --config=myConfig.yaml
`)

uploadKubeletConfigLongDesc = normalizer.LongDesc(`
uploadKubeletConfigLongDesc = cmdutil.LongDesc(`
Upload kubelet configuration extracted from the kubeadm InitConfiguration object to a ConfigMap
of the form kubelet-config-1.X in the cluster, where X is the minor version of the current (API Server) Kubernetes version.
`)

uploadKubeletConfigExample = normalizer.Examples(`
uploadKubeletConfigExample = cmdutil.Examples(`
# Upload the kubelet configuration from the kubeadm Config file to a ConfigMap in the cluster.
kubeadm init phase upload-config kubelet --config kubeadm.yaml
`)
Expand Down
2 changes: 1 addition & 1 deletion cmd/kubeadm/app/cmd/phases/join/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ go_library(
"//cmd/kubeadm/app/apis/kubeadm:go_default_library",
"//cmd/kubeadm/app/cmd/options:go_default_library",
"//cmd/kubeadm/app/cmd/phases/workflow:go_default_library",
"//cmd/kubeadm/app/cmd/util:go_default_library",
"//cmd/kubeadm/app/constants:go_default_library",
"//cmd/kubeadm/app/phases/certs:go_default_library",
"//cmd/kubeadm/app/phases/controlplane:go_default_library",
Expand All @@ -29,7 +30,6 @@ go_library(
"//cmd/kubeadm/app/preflight:go_default_library",
"//cmd/kubeadm/app/util/apiclient:go_default_library",
"//cmd/kubeadm/app/util/kubeconfig:go_default_library",
"//pkg/util/normalizer:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/util/sets:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/util/version:go_default_library",
"//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
Expand Down
4 changes: 2 additions & 2 deletions cmd/kubeadm/app/cmd/phases/join/controlplanejoin.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ import (

"k8s.io/kubernetes/cmd/kubeadm/app/cmd/options"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow"
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
kubeadmconstants "k8s.io/kubernetes/cmd/kubeadm/app/constants"
etcdphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/etcd"
markcontrolplanephase "k8s.io/kubernetes/cmd/kubeadm/app/phases/markcontrolplane"
uploadconfigphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/uploadconfig"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var controlPlaneJoinExample = normalizer.Examples(`
var controlPlaneJoinExample = cmdutil.Examples(`
# Joins a machine as a control plane instance
kubeadm join phase control-plane-join all
`)
Expand Down
4 changes: 2 additions & 2 deletions cmd/kubeadm/app/cmd/phases/join/controlplaneprepare.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@ import (
"k8s.io/klog"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/options"
"k8s.io/kubernetes/cmd/kubeadm/app/cmd/phases/workflow"
cmdutil "k8s.io/kubernetes/cmd/kubeadm/app/cmd/util"
kubeadmconstants "k8s.io/kubernetes/cmd/kubeadm/app/constants"
certsphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/certs"
"k8s.io/kubernetes/cmd/kubeadm/app/phases/controlplane"
"k8s.io/kubernetes/cmd/kubeadm/app/phases/copycerts"
kubeconfigphase "k8s.io/kubernetes/cmd/kubeadm/app/phases/kubeconfig"
kubeconfigutil "k8s.io/kubernetes/cmd/kubeadm/app/util/kubeconfig"
"k8s.io/kubernetes/pkg/util/normalizer"
)

var controlPlanePrepareExample = normalizer.Examples(`
var controlPlanePrepareExample = cmdutil.Examples(`
# Prepares the machine for serving a control plane
kubeadm join phase control-plane-prepare all
`)
Expand Down