Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insecure max bind port value to 65535 for scheduler & apiserver #79346

Merged
merged 1 commit into from Jun 25, 2019

Conversation

@ncdc
Copy link
Member

commented Jun 24, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Correct the maximum bind port value to 65535 for the insecure ports for kube-scheduler and apiserver (it was 65335, which is 200 less than what it should be).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Correct the maximum allowed insecure bind port for the kube-scheduler and kube-apiserver to 65535.
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
@ncdc

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

@sttts you want a release note?

@k8s-ci-robot k8s-ci-robot requested review from enj and Huang-Wei Jun 24, 2019
@ncdc

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

/assign @wojtek-t

@justaugustus

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Great catch, @ncdc!

@sttts

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

/lgtm
/approve

Copy link
Contributor

left a comment

/lgtm

Thanks for the fix @ncdc

@ravisantoshgudimetla

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, ravisantoshgudimetla, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roycaihw

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

/cc @yliaog

@k8s-ci-robot k8s-ci-robot requested a review from yliaog Jun 24, 2019
@yliaog

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5267a3d into kubernetes:master Jun 25, 2019
23 checks passed
23 checks passed
cla/linuxfoundation ncdc authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.