Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix insecure max bind port value to 65535 for scheduler & apiserver #79346

Merged
merged 1 commit into from Jun 25, 2019
Merged

Fix insecure max bind port value to 65535 for scheduler & apiserver #79346

merged 1 commit into from Jun 25, 2019

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Jun 24, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Correct the maximum bind port value to 65535 for the insecure ports for kube-scheduler and apiserver (it was 65335, which is 200 less than what it should be).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Correct the maximum allowed insecure bind port for the kube-scheduler and kube-apiserver to 65535.

@ncdc
Fix max port value to 65535
9bba2c9 
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
@ncdc ncdc added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 24, 2019
@ncdc ncdc requested a review from sttts June 24, 2019 19:22
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 24, 2019
@ncdc
Copy link
Member Author

ncdc commented Jun 24, 2019

@sttts you want a release note?

@ncdc
Copy link
Member Author

ncdc commented Jun 24, 2019

/assign @wojtek-t

@justaugustus
Copy link
Member

Great catch, @ncdc!

@sttts
Copy link
Contributor

sttts commented Jun 24, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2019
@sttts sttts added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 24, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 24, 2019
ravisantoshgudimetla
ravisantoshgudimetla approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the fix @ncdc

@ravisantoshgudimetla
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, ravisantoshgudimetla, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2019
@roycaihw
Copy link
Member

/cc @yliaog

@k8s-ci-robot k8s-ci-robot requested a review from yliaog June 24, 2019 21:13
@yliaog
Copy link
Contributor

yliaog commented Jun 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 5267a3d into kubernetes:master Jun 25, 2019
@ncdc ncdc deleted the fix-max-port branch February 11, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

@sttts sttts Awaiting requested review from sttts

@enj enj Awaiting requested review from enj

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@sttts sttts

@wojtek-t wojtek-t

@ravisantoshgudimetla ravisantoshgudimetla

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ncdc @justaugustus @sttts @ravisantoshgudimetla @k8s-ci-robot @roycaihw @yliaog @wojtek-t