Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #79451: kubelet: retry pod sandbox creation when containers were #79484

Merged
merged 1 commit into from
Jun 29, 2019
Merged

Automated cherry pick of #79451: kubelet: retry pod sandbox creation when containers were #79484

merged 1 commit into from
Jun 29, 2019

Conversation

yujuhong
Copy link
Contributor

Cherry pick of #79451 on release-1.13.

#79451: kubelet: retry pod sandbox creation when containers were

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 27, 2019
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@yujuhong yujuhong added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 27, 2019
@yujuhong yujuhong added this to the v1.13 milestone Jun 27, 2019
@yujuhong
Copy link
Contributor Author

/assign @dashpole

@yujuhong
Copy link
Contributor Author

/assign @aleksandra-malinowska

@dashpole
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@yujuhong
kubelet: retry pod sandbox creation when containers were never created
1c0cfe3 
If kubelet never gets past sandbox creation (i.e., never attempted to
create containers for a pod), it should retry the sandbox creation on
failure, regardless of the restart policy of the pod.
@yujuhong yujuhong force-pushed the automated-cherry-pick-of-#79451-upstream-release-1.13 branch from c40319d to 1c0cfe3 Compare June 27, 2019 17:44
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@yujuhong
Copy link
Contributor Author

Need to port a test utility function back for the unit tests.
PTAL again. Thanks

@dashpole
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@yujuhong
Copy link
Contributor Author

/test pull-kubernetes-integration

@yujuhong
Copy link
Contributor Author

/retest

@yujuhong
Copy link
Contributor Author

Failure not related to the PR:

I0627 19:26:49.203] +++ [0627 19:26:49] Downloading dependencies - this might take a while
W0627 19:26:49.476] godep: error downloading dep (bitbucket.org/bertimus9/systemstat): https://api.bitbucket.org/1.0/repositories/bertimus9/systemstat: 410 Gone
W0627 19:26:49.505] godep: error downloading dep (bitbucket.org/ww/goautoneg): https://api.bitbucket.org/1.0/repositories/ww/goautoneg: 410 Gone
W0627 19:30:23.570] godep: Error downloading some deps. Aborting restore and check.
W0627 19:30:24.263] !!! [0627 19:30:24] Call tree:

/retest

@mattjmcnaughton
Copy link
Contributor

/test pull-kubernetes-verify

Not sure if this is flake? Looks like it things from deps are missing...

@nikhita
Copy link
Member

nikhita commented Jun 28, 2019

Not sure if this is flake?

@mattjmcnaughton it's due to #79501

@yujuhong
Copy link
Contributor Author

@mattjmcnaughton it's due to #79501

Yep. Thanks for fixing that!

/retest

@yujuhong
Copy link
Contributor Author

@kubernetes/patch-release-team for approval

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jun 29, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 5a2ff43 into kubernetes:release-1.13 Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@sjpotter sjpotter Awaiting requested review from sjpotter

Assignees

@tpepper tpepper

@dashpole dashpole

@aleksandra-malinowska aleksandra-malinowska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@yujuhong @k8s-ci-robot @dashpole @mattjmcnaughton @nikhita @fejta-bot @feiskyer @tpepper @aleksandra-malinowska