Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit google DNS hostname #79731

Merged
merged 1 commit into from Jul 3, 2019
Merged

Edit google DNS hostname #79731

merged 1 commit into from Jul 3, 2019

Conversation

rajansandeep
Copy link
Contributor

@rajansandeep rajansandeep commented Jul 3, 2019 •
edited

What type of PR is this?

/kind failing-test

What this PR does / why we need it:
Updates the google DNS hostname to fix the DNS configmap failing tests.

Which issue(s) this PR fixes:

Fixes #79459

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 3, 2019
@rajansandeep
Copy link
Contributor Author

/priority critical-urgent
/sig network

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 3, 2019
BenTheElder
BenTheElder approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3c675ad into kubernetes:master Jul 3, 2019
@BenTheElder
Copy link
Member

we're going to need to cherry pick this

This was referenced Jul 3, 2019
Merged
Merged
Merged
Closed
@BenTheElder
Copy link
Member

filed for all active branches

k8s-ci-robot added a commit that referenced this pull request Jul 4, 2019
@k8s-ci-robot
Merge pull request #79748 from BenTheElder/automated-cherry-pick-of-#…
a87e9a9 
…79731-upstream-release-1.14

Automated cherry pick of #79731: edit google dns hostname
k8s-ci-robot added a commit that referenced this pull request Jul 4, 2019
@k8s-ci-robot
Merge pull request #79749 from BenTheElder/automated-cherry-pick-of-#…
0c6d31a 
…79731-upstream-release-1.13

Automated cherry pick of #79731: edit google dns hostname
k8s-ci-robot added a commit that referenced this pull request Jul 4, 2019
@k8s-ci-robot
Merge pull request #79745 from BenTheElder/automated-cherry-pick-of-#…
8e12d15 
…79731-upstream-release-1.15

Automated cherry pick of #79731: edit google dns hostname
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@bowei bowei Awaiting requested review from bowei

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@rajansandeep @k8s-ci-robot @BenTheElder