use expectEqual in framework #79771

tealee1992 · 2019-07-04T06:30:45Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2019-07-04T06:30:46Z

Welcome @tealee1992!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-07-04T06:30:53Z

Hi @tealee1992. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-07-04T06:32:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tealee1992
To complete the pull request process, please assign krzyzacy
You can assign the PR to them by writing /assign @krzyzacy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

test/e2e/framework/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tealee1992 · 2019-07-04T06:38:00Z

/assign @krzyzacy

draveness

/ok-to-test
/priority backlog
/lgtm

draveness

/assign @oomichi

tealee1992 · 2019-07-04T09:06:06Z

/retest

tealee1992 · 2019-07-05T06:46:03Z

/reset

oomichi · 2019-07-05T18:07:11Z

test/e2e/framework/pod/resource.go

@@ -672,13 +672,13 @@ func GetPodsScheduled(masterNodes sets.String, pods *v1.PodList) (scheduledPods,
 		if !masterNodes.Has(pod.Spec.NodeName) {
 			if pod.Spec.NodeName != "" {
 				_, scheduledCondition := podutil.GetPodCondition(&pod.Status, v1.PodScheduled)
-				gomega.Expect(scheduledCondition != nil).To(gomega.Equal(true))
-				gomega.Expect(scheduledCondition.Status).To(gomega.Equal(v1.ConditionTrue))
+				framework.ExpectEqual(scheduledCondition != nil, true)


The test jobs are failed like

# k8s.io/kubernetes/test/e2e/framework/pod test/e2e/framework/pod/resource.go:675:5: undefined: framework test/e2e/framework/pod/resource.go:676:5: undefined: framework test/e2e/framework/pod/resource.go:680:5: undefined: framework test/e2e/framework/pod/resource.go:681:5: undefined: framework

Because here is in the framework itself. We need to remove framework from here.

Thx! I removed theframework but it said undefined : ExpectEqual. So I think we should import framework . Now I am blocked by this ： https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/79771/pull-kubernetes-bazel-build/1147495162553831424
It just doesn't make sense - other packages are doing fine under the framework.

oomichi · 2019-07-05T18:07:34Z

test/e2e/framework/pod/resource.go

-				gomega.Expect(scheduledCondition != nil).To(gomega.Equal(true))
-				gomega.Expect(scheduledCondition.Status).To(gomega.Equal(v1.ConditionTrue))
+				framework.ExpectEqual(scheduledCondition != nil, true)
+				framework.ExpectEqual(scheduledCondition.Status, v1.ConditionTrue)


oomichi · 2019-07-05T18:07:40Z

test/e2e/framework/pod/resource.go

 				scheduledPods = append(scheduledPods, pod)
 			} else {
 				_, scheduledCondition := podutil.GetPodCondition(&pod.Status, v1.PodScheduled)
-				gomega.Expect(scheduledCondition != nil).To(gomega.Equal(true))
-				gomega.Expect(scheduledCondition.Status).To(gomega.Equal(v1.ConditionFalse))
+				framework.ExpectEqual(scheduledCondition != nil, true)


oomichi · 2019-07-05T18:07:45Z

test/e2e/framework/pod/resource.go

-				gomega.Expect(scheduledCondition != nil).To(gomega.Equal(true))
-				gomega.Expect(scheduledCondition.Status).To(gomega.Equal(v1.ConditionFalse))
+				framework.ExpectEqual(scheduledCondition != nil, true)
+				framework.ExpectEqual(scheduledCondition.Status, v1.ConditionFalse)


k8s-ci-robot · 2019-07-06T11:36:51Z

New changes are detected. LGTM label has been removed.

k8s-ci-robot · 2019-07-06T13:19:11Z

@tealee1992: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-07-06T14:00:03Z

@tealee1992: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-node-e2e-containerd	`8f7781d`	link	`/test pull-kubernetes-node-e2e-containerd`
pull-kubernetes-e2e-gce	`129152f`	link	`/test pull-kubernetes-e2e-gce`
pull-kubernetes-node-e2e	`129152f`	link	`/test pull-kubernetes-node-e2e`
pull-kubernetes-bazel-build	`4032789`	link	`/test pull-kubernetes-bazel-build`
pull-kubernetes-e2e-gce-device-plugin-gpu	`4032789`	link	`/test pull-kubernetes-e2e-gce-device-plugin-gpu`
pull-kubernetes-bazel-test	`4032789`	link	`/test pull-kubernetes-bazel-test`
pull-kubernetes-kubemark-e2e-gce-big	`4032789`	link	`/test pull-kubernetes-kubemark-e2e-gce-big`
pull-kubernetes-e2e-gce-100-performance	`4032789`	link	`/test pull-kubernetes-e2e-gce-100-performance`
pull-kubernetes-integration	`4032789`	link	`/test pull-kubernetes-integration`
pull-kubernetes-typecheck	`4032789`	link	`/test pull-kubernetes-typecheck`
pull-kubernetes-verify	`4032789`	link	`/test pull-kubernetes-verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

oomichi · 2019-07-26T18:56:26Z

@tealee1992 This makes module import a new library code.
So we need to run ./hack/update-bazel.sh and make this PR include the change of BUILD files.

oomichi · 2019-07-30T22:40:42Z

I'd like to make this move forward.
I am happy to see this update in this week, otherwise somebody else will take over.

oomichi · 2019-08-22T17:48:37Z

The original issue has been closed, so now this becomes non-mandatory.

/close

k8s-ci-robot · 2019-08-22T17:48:39Z

@oomichi: Closed this PR.

In response to this:

The original issue has been closed, so now this becomes non-mandatory.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

use expectEqual in framework

8f7781d

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2019

k8s-ci-robot requested review from BenTheElder and SataQiu July 4, 2019 06:31

k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 4, 2019

k8s-ci-robot assigned krzyzacy Jul 4, 2019

draveness approved these changes Jul 4, 2019

View reviewed changes

k8s-ci-robot assigned draveness Jul 4, 2019

k8s-ci-robot assigned oomichi Jul 4, 2019

draveness reviewed Jul 4, 2019

View reviewed changes

oomichi mentioned this pull request Jul 5, 2019

Use framework.ExpectEqual() for e2e tests #79686

Closed

29 tasks

oomichi reviewed Jul 5, 2019

View reviewed changes

use expectEqual in framework

d371702

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2019

tealee1992 added 3 commits July 6, 2019 20:18

use expectEqual in framework

129152f

use expectEqual in framework

cbaa59f

use expectEqual in framework

4032789

k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Jul 6, 2019

oomichi mentioned this pull request Jul 26, 2019

Use ExpectEqual in test/e2e/framework #80363

Closed

k8s-ci-robot closed this Aug 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use expectEqual in framework #79771

use expectEqual in framework #79771

tealee1992 commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

tealee1992 commented Jul 4, 2019

draveness left a comment

draveness left a comment

tealee1992 commented Jul 4, 2019

tealee1992 commented Jul 5, 2019

oomichi Jul 5, 2019

tealee1992 Jul 6, 2019

oomichi Jul 5, 2019

oomichi Jul 5, 2019

oomichi Jul 5, 2019

k8s-ci-robot commented Jul 6, 2019

k8s-ci-robot commented Jul 6, 2019

k8s-ci-robot commented Jul 6, 2019

oomichi commented Jul 26, 2019

oomichi commented Jul 30, 2019 •

edited

oomichi commented Aug 22, 2019

k8s-ci-robot commented Aug 22, 2019

use expectEqual in framework #79771

use expectEqual in framework #79771

Conversation

tealee1992 commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

tealee1992 commented Jul 4, 2019

draveness left a comment

Choose a reason for hiding this comment

draveness left a comment

Choose a reason for hiding this comment

tealee1992 commented Jul 4, 2019

tealee1992 commented Jul 5, 2019

oomichi Jul 5, 2019

Choose a reason for hiding this comment

tealee1992 Jul 6, 2019

Choose a reason for hiding this comment

oomichi Jul 5, 2019

Choose a reason for hiding this comment

oomichi Jul 5, 2019

Choose a reason for hiding this comment

oomichi Jul 5, 2019

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 6, 2019

k8s-ci-robot commented Jul 6, 2019

k8s-ci-robot commented Jul 6, 2019

oomichi commented Jul 26, 2019

oomichi commented Jul 30, 2019 • edited

oomichi commented Aug 22, 2019

k8s-ci-robot commented Aug 22, 2019

oomichi commented Jul 30, 2019 •

edited