New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extender bind should respect IsInterested #79804
Extender bind should respect IsInterested #79804
Conversation
Hi @yqwang-ms. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @wojtek-t |
/assign @k82cn Could you please take a look at this small fix when you free? :) |
@Huang-Wei Could you please also take a look at this? Thanks! |
/ok-to-test |
Hi @Huang-Wei All tests are passed, ready to approve? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, yqwang-ms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I proposed similar change on May 23rd: |
My PR maintains extenderBinders so that non-bind extender isn't involved in the closure. @Huang-Wei Cheers |
@tedyu Sorry for not found your PR previously. |
@yqwang-ms |
@tedyu I think it is a minor optimization given in most clusters we only have very few extenders. Anyway you can benchmark it. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
If one extender want to manage its own extended resource exclusively, such as it want to always serve the binding request for its own extended resource xxx.com/gpu exclusively (because it also needs to set additional Pod annotations to help track resource placement when binding atomically).
However, currently, during initailization, the kube scheduler will just pick any extender which has bind verb, it may picks wrong extender, such as the one interests on xxx.com/fpga.
And then when executing a Pod binding, it find that the bind extender does not interest on xxx.com/gpu, so fall back to default binder, then even though the pod is bound, but the annotations are missed to be bound together.
This PR delays the bind extender selection when executing a Pod binding, so it will find the interested extender for each pod, instead of pre-find a global one to serve all cluster binding.
Which issue(s) this PR fixes:
Fixes # NO See issue above.
Special notes for your reviewer:
Does this PR introduce a user-facing change?: