Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extender bind should respect IsInterested #79804

Merged
merged 1 commit into from Aug 16, 2019

Conversation

yqwang-ms
Copy link
Contributor

@yqwang-ms yqwang-ms commented Jul 4, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
If one extender want to manage its own extended resource exclusively, such as it want to always serve the binding request for its own extended resource xxx.com/gpu exclusively (because it also needs to set additional Pod annotations to help track resource placement when binding atomically).

However, currently, during initailization, the kube scheduler will just pick any extender which has bind verb, it may picks wrong extender, such as the one interests on xxx.com/fpga.
And then when executing a Pod binding, it find that the bind extender does not interest on xxx.com/gpu, so fall back to default binder, then even though the pod is bound, but the annotations are missed to be bound together.

This PR delays the bind extender selection when executing a Pod binding, so it will find the interested extender for each pod, instead of pre-find a global one to serve all cluster binding.

Which issue(s) this PR fixes:

Fixes # NO See issue above.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Extender bind should respect IsInterested

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @yqwang-ms. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 4, 2019
@yqwang-ms
Copy link
Contributor Author

/assign @wojtek-t

@yqwang-ms
Copy link
Contributor Author

/assign @k82cn
/assign @Huang-Wei

Could you please take a look at this small fix when you free? :)
Or could you please tell me what should I do next?
Thanks again!

@yqwang-ms
Copy link
Contributor Author

@Huang-Wei Could you please also take a look at this? Thanks!

@Huang-Wei
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2019
@yqwang-ms
Copy link
Contributor Author

Hi @Huang-Wei All tests are passed, ready to approve? :)

Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, yqwang-ms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit a56e86a into kubernetes:master Aug 16, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 16, 2019
@tedyu
Copy link
Contributor

tedyu commented Aug 16, 2019

I proposed similar change on May 23rd:

#78273

@tedyu
Copy link
Contributor

tedyu commented Aug 16, 2019

My PR maintains extenderBinders so that non-bind extender isn't involved in the closure.

@Huang-Wei
Do you think I should submit a PR for this optimization ?

Cheers

@yqwang-ms
Copy link
Contributor Author

@tedyu Sorry for not found your PR previously.
From my view, at least the relaxed validation is still worth to be in master.

@tedyu
Copy link
Contributor

tedyu commented Aug 16, 2019

@yqwang-ms
What do you think of the extenderBinders which narrows the extenders evaluated inside the closure ?

@yqwang-ms
Copy link
Contributor Author

@tedyu I think it is a minor optimization given in most clusters we only have very few extenders. Anyway you can benchmark it.
Overall, I think the extenderBinders optimization is better to have, and the relaxed validation is must have. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants