For examples/meteor: update README, minor fixes. #7985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,24 @@ | |||
| { | |||
There was a problem hiding this comment.
Are you sure you want to add v1beta1 versions of these files? They may have a rather short lifecycle.
There was a problem hiding this comment.
Ah, yes,. I thought the guidance was to copy the old files into a subdir for now. If they're not needed, I'll remove them.
There was a problem hiding this comment.
Given that v1beta1 is going away soon, I'd rather not clutter the depot with them. Please remove them.
|
Thanks for the update. Very detailed explanation! Just a minor comment. |
jeffmendoza
force-pushed
the
meteor-update
branch
from
006714e
to
f9edb4a
Compare
|
@fabioy removed v1beta1 definitions. |
|
LGTM. Will merge on green. Thank you. |
fabioy
added a commit
that referenced
this pull request
May 12, 2015
For examples/meteor: update README, minor fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make readme more generic, fix editorial issues.
Remove resource requirements from pod definitions.