Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passthrough for MountOptions for NodeStageVolume for CSI #80191

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

davidz627
Copy link
Contributor

@davidz627 davidz627 commented Jul 16, 2019

NodeStageVolume needs the MountOptions passed through for drivers to mount the global directory with the correct options.

Fixes: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#343

/kind bug
/kind failing-test
/sig storage

/assign @saad-ali @msau42
/cc @vladimirvivien @jsafrane

Pass-through volume MountOptions to global mount (NodeStageVolume) on the node for CSI

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 16, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 16, 2019
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 16, 2019
@davidz627
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 16, 2019
@msau42
Copy link
Member

msau42 commented Jul 16, 2019

Should we enable mount options in our csi driver e2es too? https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/csi.go

@davidz627
Copy link
Contributor Author

davidz627 commented Jul 16, 2019

Should we enable mount options in our csi driver e2es too? https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/csi.go

Yes, but probably separate PR: #80226

@msau42
Copy link
Member

msau42 commented Jul 16, 2019

It's good to be able to verify the fix in the same PR. We have optional pull jobs that run automatically when a sig-storage file is changed.

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 16, 2019
@davidz627
Copy link
Contributor Author

/retest

@msau42
Copy link
Member

msau42 commented Jul 16, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 835552e into kubernetes:master Jul 17, 2019
@davidz627 davidz627 deleted the fix/mountStage branch July 17, 2019 19:01
k8s-ci-robot added a commit that referenced this pull request Aug 7, 2019
…191-upstream-release-1.13

Automated cherry pick of #80191: Add passthrough for MountOptions for NodeStageVolume for
k8s-ci-robot added a commit that referenced this pull request Aug 7, 2019
…191-upstream-release-1.14

Automated cherry pick of #80191: Add passthrough for MountOptions for NodeStageVolume for
k8s-ci-robot added a commit that referenced this pull request Aug 7, 2019
…191-upstream-release-1.15

Automated cherry pick of #80191: Add passthrough for MountOptions for NodeStageVolume for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Driver doesn't mount with mount options
5 participants