-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add passthrough for MountOptions for NodeStageVolume for CSI #80191
Conversation
/priority important-soon |
Should we enable mount options in our csi driver e2es too? https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/csi.go |
Yes, but probably separate PR: #80226 |
It's good to be able to verify the fix in the same PR. We have optional pull jobs that run automatically when a sig-storage file is changed. |
72b146c
to
99690a0
Compare
/retest |
99690a0
to
b6a38d7
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidz627, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
…191-upstream-release-1.13 Automated cherry pick of #80191: Add passthrough for MountOptions for NodeStageVolume for
…191-upstream-release-1.14 Automated cherry pick of #80191: Add passthrough for MountOptions for NodeStageVolume for
…191-upstream-release-1.15 Automated cherry pick of #80191: Add passthrough for MountOptions for NodeStageVolume for
NodeStageVolume needs the MountOptions passed through for drivers to mount the global directory with the correct options.
Fixes: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#343
/kind bug
/kind failing-test
/sig storage
/assign @saad-ali @msau42
/cc @vladimirvivien @jsafrane