Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix panic in ResourceLocation in case of empty pod ip list #80260

Merged
merged 1 commit into from Jul 18, 2019
Merged

fix panic in ResourceLocation in case of empty pod ip list #80260

merged 1 commit into from Jul 18, 2019

Conversation

khenidak
Copy link
Contributor

What type of PR is this?
/kind api-change
/kind bug
/kind cleanup
What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes 54d42e6#r34326319 (cc @liggitt )

Special notes for your reviewer:
N/A

Does this PR introduce a user-facing change?:
NONE

N/A

@kubernetes/sig-network-misc

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 17, 2019
@liggitt
Copy link
Member

liggitt commented Jul 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khenidak, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt
Copy link
Member

liggitt commented Jul 17, 2019

gofmt error

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2019
@khenidak
Copy link
Contributor Author

@liggitt pushed a fix for the go-fmt issue, let us run all tests, then approve after. thanks

@liggitt
Copy link
Member

liggitt commented Jul 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2019
@khenidak
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

bowei
bowei reviewed Jul 17, 2019
View reviewed changes
pkg/registry/core/pod/strategy.go
@@ -239,6 +239,18 @@ func getPod(getter ResourceGetter, ctx context.Context, name string) (*api.Pod,
return pod, nil
}

// returns primary IP for a Pod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getPodIP returns the primary IP for a Pod. Returns an empty string if pod is nil or there are no IPs

@k8s-ci-robot k8s-ci-robot merged commit cb9c6f4 into kubernetes:master Jul 18, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@khenidak @liggitt @k8s-ci-robot @fejta-bot @bowei