Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic in ResourceLocation in case of empty pod ip list #80260

Merged
merged 1 commit into from Jul 18, 2019

Conversation

@khenidak
Copy link
Contributor

commented Jul 17, 2019

What type of PR is this?
/kind api-change
/kind bug
/kind cleanup
What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes 54d42e6#r34326319 (cc @liggitt )

Special notes for your reviewer:
N/A

Does this PR introduce a user-facing change?:
NONE

N/A

@kubernetes/sig-network-misc

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khenidak, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 17, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

gofmt error

@khenidak khenidak force-pushed the khenidak:fix-panic-in-pod-strategy branch from 356acee to 41f3135 Jul 17, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 17, 2019
@khenidak

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

@liggitt pushed a fix for the go-fmt issue, let us run all tests, then approve after. thanks

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 17, 2019
@khenidak

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

/test pull-kubernetes-e2e-gce

@@ -239,6 +239,18 @@ func getPod(getter ResourceGetter, ctx context.Context, name string) (*api.Pod,
return pod, nil
}

// returns primary IP for a Pod

This comment has been minimized.

Copy link
@bowei

bowei Jul 17, 2019

Member

getPodIP returns the primary IP for a Pod. Returns an empty string if pod is nil or there are no IPs

@k8s-ci-robot k8s-ci-robot merged commit cb9c6f4 into kubernetes:master Jul 18, 2019
23 checks passed
23 checks passed
cla/linuxfoundation khenidak authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.