Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing error check #80700

Merged
merged 1 commit into from May 11, 2020
Merged

Add missing error check #80700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/controller/podautoscaler/horizontal.go
View file
Open in desktop
Expand Up @@ -342,6 +342,9 @@ func (a *HorizontalController) reconcileKey(key string) (deleted bool, err error
delete(a.recommendations, key)
return true, nil
}
if err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

return false, err
}

return false, a.reconcileAutoscaler(hpa, key)
}
Expand Down