New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralizes images into agnhost (part 4) #81170
Merged
k8s-ci-robot
merged 1 commit into
kubernetes:master
from
claudiubelu:test-images/centralize-image-to-agnhost-part-4
Jan 13, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2.8 | ||
| 2.9 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| # Copyright 2019 The Kubernetes Authors. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| Param( | ||
| [string]$FileName = $(throw "-FileName is required.") | ||
| ) | ||
|
|
||
|
|
||
| # read = read data | read attributes | ||
| $READ_PERMISSIONS = 0x0001 -bor 0x0080 | ||
|
|
||
| # write = write data | append data | write attributes | write EA | ||
| $WRITE_PERMISSIONS = 0x0002 -bor 0x0004 -bor 0x0100 -bor 0x0010 | ||
|
|
||
| # execute = read data | file execute | ||
| $EXECUTE_PERMISSIONS = 0x0001 -bor 0x0020 | ||
|
|
||
|
|
||
| function GetFilePermissions($path) { | ||
| $objPath = "Win32_LogicalFileSecuritySetting='$path'" | ||
| $output = Invoke-WmiMethod -Namespace root/cimv2 -Path $objPath -Name GetSecurityDescriptor | ||
|
|
||
| if ($output.ReturnValue -ne 0) { | ||
| $retVal = $output.ReturnValue | ||
| Write-Error "GetSecurityDescriptor invocation failed with code: $retVal" | ||
| exit 1 | ||
| } | ||
|
|
||
| $fileSD = $output.Descriptor | ||
| $fileOwnerGroup = $fileSD.Group | ||
| $fileOwner = $fileSD.Owner | ||
|
|
||
| if ($fileOwnerGroup.Name -eq $null -and $fileOwnerGroup.Domain -eq $null) { | ||
| # the file owner's group is not recognized. Check if the Owner itself is | ||
| # a group, and if so, default the group to it. | ||
| net user $fileOwner.Name > $null 2> $null | ||
| if (-not $?) { | ||
| $fileOwnerGroup = $fileOwner | ||
| } | ||
|
|
||
| } | ||
|
|
||
| $userMask = 0 | ||
| $groupMask = 0 | ||
| $otherMask = 0 | ||
|
|
||
| foreach ($ace in $fileSD.DACL) { | ||
| $mask = 0 | ||
| if ($ace.AceType -ne 0) { | ||
| # not an Allow ACE, skip. | ||
| continue | ||
| } | ||
|
|
||
| # convert mask. | ||
| if ( ($ace.AccessMask -band $READ_PERMISSIONS) -eq $READ_PERMISSIONS ) { | ||
| $mask = $mask -bor 4 | ||
| } | ||
| if ( ($ace.AccessMask -band $WRITE_PERMISSIONS) -eq $WRITE_PERMISSIONS ) { | ||
| $mask = $mask -bor 2 | ||
| } | ||
| if ( ($ace.AccessMask -band $EXECUTE_PERMISSIONS) -eq $EXECUTE_PERMISSIONS ) { | ||
| $mask = $mask -bor 1 | ||
| } | ||
|
|
||
| # detect mask type. | ||
| if ($ace.Trustee.Equals($fileOwner)) { | ||
| $userMask = $mask | ||
| } | ||
| if ($ace.Trustee.Equals($fileOwnerGroup)) { | ||
| $groupMask = $mask | ||
| } | ||
| if ($ace.Trustee.Name.ToLower() -eq "users") { | ||
| $otherMask = $mask | ||
| } | ||
| } | ||
|
|
||
| return "$userMask$groupMask$otherMask" | ||
| } | ||
|
|
||
| $mask = GetFilePermissions($FileName) | ||
| if (-not $?) { | ||
| exit 1 | ||
| } | ||
|
|
||
| # print the permission mask Linux-style. | ||
| echo "0$mask" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lack sufficient windows expertise to really review this; can we get someone else to take a look at this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, it's what it has been used in tests like
should be consumable from pods in volume with mappingssince about 1 year. You can see it here: https://testgrid.k8s.io/sig-windows#aks-engine-azure-windows-master