Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split HumanReadablePrinter struct into generator and printer structs #81404

Merged
merged 2 commits into from Aug 21, 2019
Merged

Split HumanReadablePrinter struct into generator and printer structs #81404

merged 2 commits into from Aug 21, 2019

Conversation

seans3
Copy link
Contributor

@seans3 seans3 commented Aug 14, 2019 •
edited

  • Continues progress toward cleaning up printing, by splitting the HumanReadablePrinter struct into HumanReadableGenerator and HumanReadablePrinter structs.
  • Updates printer tests which previously only called PrintObj() to first generate the table, then call PrintObj() on the table.
  • These internalversion printer tests will eventually be removed completely; a couple have been removed now because they no longer make sense after the split.
  • The next step is to move decorateTable() exclusively to table printing (and out of table generation).

/kind cleanup
/sig cli
/area kubectl
/area code-organization
/priority important-soon

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/kubectl area/code-organization Issues or PRs related to kubernetes code organization priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2019
@seans3
Copy link
Contributor Author

seans3 commented Aug 14, 2019

/assign @liggitt

@seans3
Copy link
Contributor Author

seans3 commented Aug 15, 2019

/retest

2 similar comments
@seans3
Copy link
Contributor Author

seans3 commented Aug 15, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Aug 16, 2019

/retest

@seans3
Copy link
Contributor Author

seans3 commented Aug 19, 2019

/retest

@liggitt
Copy link
Member

liggitt commented Aug 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2cfef83 into kubernetes:master Aug 21, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 21, 2019
@seans3 seans3 deleted the tableprinter-cleanup branch August 21, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seans3 @liggitt @k8s-ci-robot