New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of service comments in iptables #81563
Conversation
/cc thockin |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/assign @thockin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
/retest |
This will make "appendServiceCommentLocked" do what it looks like it does. The current implementation is just plain dead code, as the append func does not edit in place. As discussed in the original PR, we could create a new flag to allow the user to enable the comments when needed. This will increase the size of the iptables rules, but not the way they work. Original PR: kubernetes#65755
5e19b84
to
3891807
Compare
/retest |
/test pull-kubernetes-e2e-gce |
Had to update some tests that was created after this PR. Should be good to go again now. @thockin |
I think that the commits should we squashed so the new functionality and the tests merge together in one commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: odinuge, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#81886 includes this and is already squashed and approved (and doesn't rename the service port, which I just noticed) |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Stumbled upon this when debugging some network issues with debian buster (ref. #71305, hopefully we can get that sorted out soon).
This will make "appendServiceCommentLocked" do what it looks like it
does. The current implementation is just plain dead code, as the
append func does not edit in place.
As discussed in the original PR, we could create a new flag to allow the
user to enable the comments when needed. This will increase the size of
the iptables rules, but not the way they work.
Original PR:
#65755
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Guess we can rewrite the func to something like this, if that is preferable:
Do we need a release note for this? 馃
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: