Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out of loop when finalizer is found #82053

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@tedyu
Copy link
Contributor

commented Aug 28, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
In WaitForServiceUpdatedWithFinalizer, when the LoadBalancerCleanupFinalizer is found, we can come out of the loop.

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 28, 2019

/assign @MrHohn

Copy link
Contributor

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/priority backlog

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

/hold

per release-managers discussion, holding low-priority, non-milestone-targeted PRs in order to free merge pool bandwidth for 1.16-targeted PRs

feel free to unhold once there are no lgtm+approve+green 1.16-targeted PRs remaining.

@lachie83

This comment has been minimized.

Copy link
Member

commented Aug 30, 2019

/hold cancel

@timothysc timothysc added this to the v1.17 milestone Sep 10, 2019
@timothysc timothysc removed their request for review Sep 10, 2019
@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

/test pull-kubernetes-integration

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

/test pull-kubernetes-node-e2e

@tedyu

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit 439e92b into kubernetes:master Sep 12, 2019
24 checks passed
24 checks passed
cla/linuxfoundation tedyu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-conformance-kind-ipv6 Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.