Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Convert existing function to default queue sort plugin #82204

Closed
wants to merge 2 commits into from
Closed

[WIP]Convert existing function to default queue sort plugin #82204

wants to merge 2 commits into from

Conversation

hex108
Copy link
Contributor

@hex108 hex108 commented Aug 31, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Convert existing function to default queue sort plugin, it will be used if admin does not configure queue sort plugin, otherwise use configured queue sort plugin.

Which issue(s) this PR fixes:

Fixes #80304

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Convert existing function to default queue sort plugin whose name is "default-queue-sort-plugin", it will be used if admin does not configure queue sort plugin, otherwise use configured queue sort plugin.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig scheduling

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hex108
To complete the pull request process, please assign bsalamat, cblecker
You can assign the PR to them by writing /assign @bsalamat @cblecker in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 31, 2019
@hex108 hex108 mentioned this pull request Aug 31, 2019
Closed
@hex108 hex108 force-pushed the default_queue_sort branch 3 times, most recently from debf66f to bfecfff Compare August 31, 2019 13:45
@hex108 hex108 changed the title Convert existing function to default queue sort plugin [WIP]Convert existing function to default queue sort plugin Aug 31, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2019
@k8s-ci-robot
Copy link
Contributor

@hex108: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 89d44ef link /test pull-kubernetes-bazel-test
pull-kubernetes-integration 89d44ef link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hex108
hex108 commented Sep 13, 2019
View reviewed changes
pkg/scheduler/framework/v1alpha1/framework.go
}
if len(plugins.QueueSort.Enabled) == 0 {
plugins.QueueSort.Enabled = append(plugins.QueueSort.Enabled,
config.Plugin{Name: frameworkplugins.DefaultQueueSortPluginName})
Copy link
Contributor Author

@hex108 hex108 Sep 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use k8s.io/kubernetes/pkg/scheduler/framework/plugins/queuesort.Name( "default-queue-sort-plugin"), there will be an import cycle(note that k8s.io/kubernetes/pkg/scheduler/framework/plugins/queuesort has imported k8s.io/kubernetes/pkg/scheduler/framework/v1alpha1), so I introduce frameworkplugins.DefaultQueueSortPluginName to resolve it.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 12, 2019
@k8s-ci-robot
Copy link
Contributor

@hex108: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 11, 2020
@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 11, 2020
@hex108 hex108 closed this Jan 17, 2020
@hex108 hex108 deleted the default_queue_sort branch January 17, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draveness draveness Awaiting requested review from draveness

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees
No one assigned
Labels
area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add default queue sort plugins for scheduler framework
3 participants
@hex108 @k8s-ci-robot @fejta-bot