Remove /Validate endpoint #8224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bgrant0607 FYI. |
| @@ -501,8 +499,6 @@ func (m *Master) init(c *Config) { | |||
| m.mux.HandleFunc("/", apiserver.IndexHandler(m.handlerContainer, m.muxHelper)) | |||
| } | |||
|
|
|||
| // TODO: This is now deprecated. Should be removed once client dependencies are gone. | |||
| apiserver.InstallValidator(m.muxHelper, func() map[string]apiserver.Server { return m.getServersToValidate(c, true) }) | |||
There was a problem hiding this comment.
Can you rip out the InstallValidator function as well?
|
Thanks. Ref #7092. See also #7775 (comment) |
| if len(servers) != 7 { | ||
| t.Errorf("unexpected server list: %#v", servers) | ||
| } | ||
| for _, server := range []string{"scheduler", "controller-manager", "etcd-0", "etcd-1", "etcd-2", "node-0", "node-1"} { |
There was a problem hiding this comment.
why is this completely removed? shouldn't just the nodes be removed from the list?
There was a problem hiding this comment.
Yes, that is what the code below does (out of frame of the diff). This first chunk validates that the getServersToValidate()flow works with nodes included, which we will no longer support.
cjcullen
force-pushed
the
nodenames
branch
3 times, most recently
from
a10ef64
to
2789aff
Compare
| // TODO: This endpoint is deprecated and should be removed at some point. | ||
| // Use "componentstatus" API instead. | ||
| func InstallValidator(mux Mux, servers func() map[string]Server) { | ||
| mux.Handle("/validate", NewValidator(servers)) |
There was a problem hiding this comment.
Aaaand its gone. Took down a bunch of other dead code with it.
|
LGTM |
bgrant0607
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one step towards fixing #2462. GKE no longer uses the validate endpoint, and its been deprecated for a couple weeks now, so I want to chop it off.