Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace 200 with http.StatusOK #82644

Merged
merged 1 commit into from Sep 19, 2019
Merged

replace 200 with http.StatusOK #82644

merged 1 commit into from Sep 19, 2019

Conversation

ZP-AlwaysWin
Copy link
Contributor

@ZP-AlwaysWin ZP-AlwaysWin commented Sep 12, 2019 •
edited

What this PR does / why we need it:

replace 200 with http.StatusOK

Which issue(s) this PR fixes

Fixes #
/kind cleanup

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ZP-AlwaysWin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2019
@ZP-AlwaysWin
Copy link
Contributor Author

/assign @seans3

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 12, 2019
@neolit123
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 12, 2019
@neolit123
Copy link
Member

thanks for the PR
/lgtm
/ok-to-test
/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 12, 2019
@ZP-AlwaysWin
Copy link
Contributor Author

thanks for the PR
/lgtm
/ok-to-test
/kind cleanup
/priority backlog

hi @neolit123
Thank you for reviewing the code for me.
Now that you have passed the automated test, can you approve it merge to master?

@ZP-AlwaysWin
Copy link
Contributor Author

/assign @liggitt
PTAL

@liggitt
Copy link
Member

liggitt commented Sep 19, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, ZP-AlwaysWin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 29d05ae into kubernetes:master Sep 19, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 19, 2019
@ZP-AlwaysWin ZP-AlwaysWin deleted the dev01 branch September 19, 2019 06:16
@ZP-AlwaysWin ZP-AlwaysWin mentioned this pull request Sep 25, 2019
Closed
6 tasks
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#82644 from ZP-AlwaysWin/dev01
ff65a06 
replace 200 with http.StatusOK

Kubernetes-commit: 29d05ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adohe-zz adohe-zz Awaiting requested review from adohe-zz

@shiywang shiywang Awaiting requested review from shiywang

Assignees

@neolit123 neolit123

@liggitt liggitt

@adohe-zz adohe-zz

@shiywang shiywang

@seans3 seans3

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ZP-AlwaysWin @k8s-ci-robot @neolit123 @liggitt @adohe-zz @shiywang @seans3 @deads2k