fix compiling failure: execvp: /bin/bash: Argument list too long #82777

hongxu-jia · 2019-09-17T06:58:35Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Fix compiling failure: execvp: /bin/bash: Argument list too long

Which issue(s) this PR fixes:
Use GNU Make 4.2.1(such as fedora-29) to build k8s in a long directory,
it failed with `execvp: /bin/bash: Argument list too long'
[snip]
$ cd /buildarea1/hjia/wrlinux-1019/I_/suspect_/that_/if_/you_/create_/your_/project_/in_/a_/very_/deep_/directory/build_master-wr_qemux86-64_faw_2019090509/build/tmp-glibc/work/core2-64-wrs-linux/kubernetes/v1.16.0-alpha+git7054e3ead7e1a00ca6ac3ec47ea355b76061a35a-r0/kubernetes-v1.16.0-alpha+git7054e3ead7e1a00ca6ac3ec47ea355b76061a35a/src/import
$ make cross KUBE_BUILD_PLATFORMS=linux/amd64 GOLDFLAGS=""
|+++ [0804 16:38:32] Building go targets for linux/amd64:
| ./vendor/k8s.io/code-generator/cmd/deepcopy-gen
|make[1]: execvp: /bin/bash: Argument list too long
|make[1]: *** [Makefile.generated_files:184: pkg/kubectl/cmd/testing/zz_generated.deepcopy.go] Error 127
|make: *** [Makefile:557: generated_files] Error 2
...
[snip]

From make manual [1]
$?
The names of all the prerequisites that are newer than the target, with spaces between them.

While two `$?' was passed to bash in a line, it caused above failure,
drop a duplicated one could workaround the issue.

[1] https://www.gnu.org/software/make/manual/html_node/Automatic-Variables.html

Signed-off-by: Hongxu Jia hongxu.jia@windriver.com

Fixes #
#82852

Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

Use GNU Make 4.2.1(such as fedora-29) to build k8s in a long directory, it failed with `execvp: /bin/bash: Argument list too long' [snip] $ cd /buildarea1/hjia/wrlinux-1019/I_/suspect_/that_/if_/you_/create_/your_/project_/in_/a_/very_/deep_/directory/build_master-wr_qemux86-64_faw_2019090509/build/tmp-glibc/work/core2-64-wrs-linux/kubernetes/v1.16.0-alpha+git7054e3ead7e1a00ca6ac3ec47ea355b76061a35a-r0/kubernetes-v1.16.0-alpha+git7054e3ead7e1a00ca6ac3ec47ea355b76061a35a/src/import $ make cross KUBE_BUILD_PLATFORMS=linux/amd64 GOLDFLAGS="" |+++ [0804 16:38:32] Building go targets for linux/amd64: | ./vendor/k8s.io/code-generator/cmd/deepcopy-gen |make[1]: execvp: /bin/bash: Argument list too long |make[1]: *** [Makefile.generated_files:184: pkg/kubectl/cmd/testing/zz_generated.deepcopy.go] Error 127 |make: *** [Makefile:557: generated_files] Error 2 ... [snip] From make manual [1] $? The names of all the prerequisites that are newer than the target, with spaces between them. While two `$?' was passed to bash in a line, it caused above failure, drop a duplicated one could workaround the issue. [1] https://www.gnu.org/software/make/manual/html_node/Automatic-Variables.html Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>

k8s-ci-robot · 2019-09-17T06:58:36Z

Welcome @hongxu-jia!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-09-17T06:58:40Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-09-17T06:58:42Z

Hi @hongxu-jia. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hongxu-jia · 2019-09-17T07:16:35Z

I signed it

fejta · 2019-09-17T19:28:57Z

/uncc
/assign @thockin

thockin · 2019-09-17T20:06:35Z

build/root/Makefile.generated_files

@@ -182,7 +182,7 @@ $(META_DIR)/$(DEEPCOPY_GEN).todo: $(DEEPCOPY_FILES)

 $(DEEPCOPY_FILES): $(DEEPCOPY_GEN)
 	if [[ "$(DBG_CODEGEN)" == 1 ]]; then        \
-	    echo "DBG: deepcopy needed $(@D): $?";  \
+	    echo "DBG: deepcopy needed $(@D):";  \


How about "DBG: deepcopy needed $(@D): $(wordlist 1,3,$?)" so we list a few files (some comment for all 3)

Actually, you know what - skip this. We're going to ls anyway.

@thockin, Yes, you are right

thockin

Thanks!

/lgtm
/approve

k8s-ci-robot · 2019-09-17T20:08:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongxu-jia, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~build/OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hongxu-jia · 2019-09-18T01:29:54Z

@hongxu-jia: The following test failed, say /retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-100-performance 2ab47f9 link /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I am afraid there is no relation between the PR and the failure
//Hongxu

thockin · 2019-09-18T04:03:56Z

/retest

…

On Tue, Sep 17, 2019, 6:32 PM Hongxu Jia ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In build/root/Makefile.generated_files <#82777 (comment)> : > @@ -182,7 +182,7 @@ $(META_DIR)/$(DEEPCOPY_GEN).todo: $(DEEPCOPY_FILES) $(DEEPCOPY_FILES): $(DEEPCOPY_GEN) if [[ "$(DBG_CODEGEN)" == 1 ]]; then \ - echo "DBG: deepcopy needed ***@***.***): $?"; \ + echo "DBG: deepcopy needed ***@***.***):"; \ @thockin <https://github.com/thockin>, Yes, you are right — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#82777?email_source=notifications&email_token=ABKWAVADGFQEYF4IHCZVHVTQKGAJPA5CNFSM4IXLUE42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCFBV7DI#discussion_r325449165>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKWAVG4ZB5YH3SSMGUAOOLQKGAJPANCNFSM4IXLUE4Q> .

hongxu-jia · 2019-09-19T01:49:40Z

/release-note-none

hongxu-jia · 2019-09-19T03:12:10Z

I am not sure what to sig, but @thockin, I found you are in SIG network
/sig network

hongxu-jia · 2019-09-19T03:12:42Z

/sig testing

hongxu-jia · 2019-09-19T03:14:46Z

This is my first time to submit pull request to k8s,
I learn a lot about how to contribute

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 17, 2019

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 17, 2019

k8s-ci-robot requested review from fejta and lavalamp September 17, 2019 06:59

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 17, 2019

k8s-ci-robot assigned thockin Sep 17, 2019

k8s-ci-robot removed the request for review from fejta September 17, 2019 19:28

thockin reviewed Sep 17, 2019

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 19, 2019

k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2019

k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 19, 2019

k8s-ci-robot merged commit 92107f3 into kubernetes:master Sep 19, 2019

k8s-ci-robot added this to the v1.17 milestone Sep 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix compiling failure: execvp: /bin/bash: Argument list too long #82777

fix compiling failure: execvp: /bin/bash: Argument list too long #82777

hongxu-jia commented Sep 17, 2019 •

edited

k8s-ci-robot commented Sep 17, 2019

k8s-ci-robot commented Sep 17, 2019

k8s-ci-robot commented Sep 17, 2019

hongxu-jia commented Sep 17, 2019

fejta commented Sep 17, 2019

thockin Sep 17, 2019

thockin Sep 17, 2019

hongxu-jia Sep 18, 2019

thockin left a comment

k8s-ci-robot commented Sep 17, 2019

hongxu-jia commented Sep 18, 2019

thockin commented Sep 18, 2019 via email

hongxu-jia commented Sep 19, 2019

hongxu-jia commented Sep 19, 2019

hongxu-jia commented Sep 19, 2019

hongxu-jia commented Sep 19, 2019

fix compiling failure: execvp: /bin/bash: Argument list too long #82777

fix compiling failure: execvp: /bin/bash: Argument list too long #82777

Conversation

hongxu-jia commented Sep 17, 2019 • edited

k8s-ci-robot commented Sep 17, 2019

k8s-ci-robot commented Sep 17, 2019

k8s-ci-robot commented Sep 17, 2019

hongxu-jia commented Sep 17, 2019

fejta commented Sep 17, 2019

thockin Sep 17, 2019

Choose a reason for hiding this comment

thockin Sep 17, 2019

Choose a reason for hiding this comment

hongxu-jia Sep 18, 2019

Choose a reason for hiding this comment

thockin left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 17, 2019

hongxu-jia commented Sep 18, 2019

thockin commented Sep 18, 2019 via email

hongxu-jia commented Sep 19, 2019

hongxu-jia commented Sep 19, 2019

hongxu-jia commented Sep 19, 2019

hongxu-jia commented Sep 19, 2019

hongxu-jia commented Sep 17, 2019 •

edited