-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary (inefficient) manual conversions #82780
Remove unnecessary (inefficient) manual conversions #82780
Conversation
d4ad089
to
98925df
Compare
98925df
to
12bbbcc
Compare
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/lgtm very nice cleanup, glad to see these duplicate manual conversions go |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks. I'm planning to do a bit more look into what else can be removed in other package - I think those aren't the only ones that aren't needed... |
agreed. even the ones that are needed should be simplified and switched to a pattern like:
|
Ref #82484