update to use go1.13.4

build/build-image/cross/Dockerfile

@@ -15,7 +15,7 @@
 # This file creates a standard build environment for building cross
 # platform go binary for the architecture kubernetes cares about.
 
-FROM golang:1.12.12
+FROM golang:1.13.4
 
 ENV GOARM 7
 ENV KUBE_DYNAMIC_CROSSPLATFORMS \

build/build-image/cross/VERSION

@@ -1 +1 @@
-v1.12.12-1
+v1.13.4-1

build/dependencies.yaml

@@ -34,7 +34,7 @@ dependencies:
 
 
   - name: "golang"
-    version: 1.12.12
+    version: 1.13.4
     refPaths:
     - path: build/build-image/cross/Dockerfile
       match: "golang:"

build/root/WORKSPACE

@@ -44,16 +44,16 @@ http_archive(
 
 http_archive(
     name = "io_bazel_rules_go",
-    sha256 = "b480589f57e8b09f4b0892437b9afe889e0d6660e92f5d53d3f0546c01e67ca5",
-    urls = mirror("https://github.com/bazelbuild/rules_go/releases/download/v0.19.7/rules_go-v0.19.7.tar.gz"),
+    sha256 = "9976c2572587aa71f81b502cc870ef8058f6de37f5fcfaade6a5996934b4a324",
+    urls = mirror("https://github.com/bazelbuild/rules_go/releases/download/v0.19.8/rules_go-v0.19.8.tar.gz"),
 )
 
 load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
 
 go_rules_dependencies()
 
 go_register_toolchains(
-    go_version = "1.12.12",
+    go_version = "1.13.4",
 )
 
 http_archive(

build/tools.go

@@ -37,5 +37,5 @@ import (
 	_ "k8s.io/gengo/examples/import-boss/generators"
 	_ "k8s.io/gengo/examples/set-gen/generators"
 	_ "k8s.io/kube-openapi/cmd/openapi-gen"
-	_ "k8s.io/repo-infra/kazel"
+	_ "k8s.io/repo-infra/cmd/kazel"
 )

cmd/kube-proxy/app/BUILD

@@ -104,6 +104,13 @@ go_library(
             "//staging/src/k8s.io/apimachinery/pkg/util/net:go_default_library",
             "//vendor/k8s.io/utils/net:go_default_library",
         ],
+        "@io_bazel_rules_go//go/platform:ios": [
+            "//pkg/proxy/metrics:go_default_library",
+            "//pkg/util/node:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/types:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/util/net:go_default_library",
+            "//vendor/k8s.io/utils/net:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//pkg/proxy/metrics:go_default_library",
             "//pkg/util/node:go_default_library",
@@ -187,6 +194,9 @@ go_test(
         "@io_bazel_rules_go//go/platform:freebsd": [
             "//pkg/proxy/ipvs:go_default_library",
         ],
+        "@io_bazel_rules_go//go/platform:ios": [
+            "//pkg/proxy/ipvs:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//pkg/proxy/ipvs:go_default_library",
         ],

cmd/kubeadm/app/preflight/BUILD

@@ -34,6 +34,9 @@ go_library(
         "//vendor/k8s.io/utils/exec:go_default_library",
         "//vendor/k8s.io/utils/net:go_default_library",
     ] + select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//cmd/kubeadm/app/util:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//cmd/kubeadm/app/util:go_default_library",
         ],

cmd/kubelet/app/BUILD

@@ -146,6 +146,9 @@ go_library(
         "//vendor/k8s.io/klog:go_default_library",
         "//vendor/k8s.io/utils/exec:go_default_library",
     ] + select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//vendor/k8s.io/utils/inotify:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//vendor/k8s.io/utils/inotify:go_default_library",
         ],

cmd/kubelet/app/options/BUILD

@@ -42,6 +42,15 @@ go_library(
         "//vendor/github.com/spf13/pflag:go_default_library",
         "//vendor/k8s.io/klog:go_default_library",
     ] + select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//vendor/github.com/google/cadvisor/container/common:go_default_library",
+            "//vendor/github.com/google/cadvisor/container/containerd:go_default_library",
+            "//vendor/github.com/google/cadvisor/container/docker:go_default_library",
+            "//vendor/github.com/google/cadvisor/container/raw:go_default_library",
+            "//vendor/github.com/google/cadvisor/machine:go_default_library",
+            "//vendor/github.com/google/cadvisor/manager:go_default_library",
+            "//vendor/github.com/google/cadvisor/storage:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//vendor/github.com/google/cadvisor/container/common:go_default_library",
             "//vendor/github.com/google/cadvisor/container/containerd:go_default_library",

hack/jenkins/benchmark-dockerized.sh

@@ -38,6 +38,11 @@ retry() {
 
 export PATH=${GOPATH}/bin:${PWD}/third_party/etcd:/usr/local/go/bin:${PATH}
 
+# Until all GOPATH references are removed from all build scripts as well,
+# explicitly disable module mode to avoid picking up user-set GO111MODULE preferences.
+# As individual scripts make use of go modules, they can explicitly set GO111MODULE=on
+export GO111MODULE=off
+
 go install k8s.io/kubernetes/vendor/github.com/cespare/prettybench
 go install k8s.io/kubernetes/vendor/gotest.tools/gotestsum
 

hack/jenkins/test-dockerized.sh

@@ -37,6 +37,11 @@ retry() {
 
 export PATH=${GOPATH}/bin:${PWD}/third_party/etcd:/usr/local/go/bin:${PATH}
 
+# Until all GOPATH references are removed from all build scripts as well,
+# explicitly disable module mode to avoid picking up user-set GO111MODULE preferences.
+# As individual scripts make use of go modules, they can explicitly set GO111MODULE=on
+export GO111MODULE=off
+
 go install k8s.io/kubernetes/vendor/gotest.tools/gotestsum
 
 # Enable the Go race detector.

hack/lib/golang.sh

@@ -468,7 +468,7 @@ EOF
   local go_version
   IFS=" " read -ra go_version <<< "$(go version)"
   local minimum_go_version
-  minimum_go_version=go1.12.4
+  minimum_go_version=go1.13.4
   if [[ "${minimum_go_version}" != $(echo -e "${minimum_go_version}\n${go_version[2]}" | sort -s -t. -k 1,1 -k 2,2n -k 3,3n | head -n1) && "${go_version[2]}" != "devel" ]]; then
     kube::log::usage_from_stdin <<EOF
 Detected go version: ${go_version[*]}.

hack/lib/init.sh

@@ -23,10 +23,10 @@ set -o pipefail
 unset CDPATH
 
 # Until all GOPATH references are removed from all build scripts as well,
-# explicitly reset to auto mode to avoid picking up user-set GO111MODULE preferences.
+# explicitly disable module mode to avoid picking up user-set GO111MODULE preferences.
 # As individual scripts (like hack/update-vendor.sh) make use of go modules,
 # they can explicitly set GO111MODULE=on
-export GO111MODULE=auto
+export GO111MODULE=off
 
 # The root of the build/dist directory
 KUBE_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/../.." && pwd -P)"

hack/make-rules/test.sh

@@ -250,7 +250,7 @@ produceJUnitXMLReport() {
 
   if ! command -v gotestsum >/dev/null 2>&1; then
     kube::log::error "gotestsum not found; please install with " \
-      "go install k8s.io/kubernetes/vendor/gotest.tools/gotestsum"
+      "GO111MODULE=off go install k8s.io/kubernetes/vendor/gotest.tools/gotestsum"
     return
   fi
   gotestsum --junitfile "${junit_xml_filename}" --raw-command cat "${junit_filename_prefix}"*.stdout

hack/pin-dependency.sh

@@ -62,7 +62,7 @@ mkdir -p "${_tmp}"
 
 # Add the require directive
 echo "Running: go get ${dep}@${sha}"
-go get -m -d "${dep}@${sha}"
+go get -d "${dep}@${sha}"
 
 # Find the resolved version
 rev=$(go mod edit -json | jq -r ".Require[] | select(.Path == \"${dep}\") | .Version")

hack/update-bazel.sh

@@ -28,7 +28,7 @@ PATH="${GOBIN}:${PATH}"
 pushd "${KUBE_ROOT}/vendor"
   go install ./github.com/bazelbuild/bazel-gazelle/cmd/gazelle
   go install ./github.com/bazelbuild/buildtools/buildozer
-  go install ./k8s.io/repo-infra/kazel
+  go install ./k8s.io/repo-infra/cmd/kazel
 popd
 
 # Find all of the staging repos.

pkg/kubelet/BUILD

@@ -249,6 +249,9 @@ go_test(
         "//vendor/github.com/stretchr/testify/assert:go_default_library",
         "//vendor/github.com/stretchr/testify/require:go_default_library",
     ] + select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//staging/src/k8s.io/cri-api/pkg/apis/runtime/v1alpha2:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//staging/src/k8s.io/cri-api/pkg/apis/runtime/v1alpha2:go_default_library",
         ],

pkg/kubelet/cadvisor/BUILD

@@ -28,6 +28,21 @@ go_library(
         "//vendor/github.com/google/cadvisor/info/v1:go_default_library",
         "//vendor/github.com/google/cadvisor/info/v2:go_default_library",
     ] + select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//vendor/github.com/google/cadvisor/cache/memory:go_default_library",
+            "//vendor/github.com/google/cadvisor/container:go_default_library",
+            "//vendor/github.com/google/cadvisor/container/containerd/install:go_default_library",
+            "//vendor/github.com/google/cadvisor/container/crio/install:go_default_library",
+            "//vendor/github.com/google/cadvisor/container/docker/install:go_default_library",
+            "//vendor/github.com/google/cadvisor/container/systemd/install:go_default_library",
+            "//vendor/github.com/google/cadvisor/fs:go_default_library",
+            "//vendor/github.com/google/cadvisor/manager:go_default_library",
+            "//vendor/github.com/google/cadvisor/utils/cloudinfo/aws:go_default_library",
+            "//vendor/github.com/google/cadvisor/utils/cloudinfo/azure:go_default_library",
+            "//vendor/github.com/google/cadvisor/utils/cloudinfo/gce:go_default_library",
+            "//vendor/github.com/google/cadvisor/utils/sysfs:go_default_library",
+            "//vendor/k8s.io/klog:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//vendor/github.com/google/cadvisor/cache/memory:go_default_library",
             "//vendor/github.com/google/cadvisor/container:go_default_library",
@@ -55,6 +70,13 @@ go_test(
     srcs = ["util_test.go"],
     embed = [":go_default_library"],
     deps = select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//staging/src/k8s.io/api/core/v1:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/api/resource:go_default_library",
+            "//vendor/github.com/google/cadvisor/container/crio:go_default_library",
+            "//vendor/github.com/google/cadvisor/info/v1:go_default_library",
+            "//vendor/github.com/stretchr/testify/assert:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//staging/src/k8s.io/api/core/v1:go_default_library",
             "//staging/src/k8s.io/apimachinery/pkg/api/resource:go_default_library",

pkg/kubelet/cm/BUILD

@@ -45,9 +45,34 @@ go_library(
         "//vendor/k8s.io/klog:go_default_library",
     ] + select({
         "@io_bazel_rules_go//go/platform:android": [
+            "//pkg/api/v1/resource:go_default_library",
+            "//pkg/apis/core/v1/helper:go_default_library",
+            "//pkg/apis/core/v1/helper/qos:go_default_library",
             "//pkg/kubelet/cadvisor:go_default_library",
+            "//pkg/kubelet/cm/cpumanager/topology:go_default_library",
+            "//pkg/kubelet/cm/devicemanager:go_default_library",
+            "//pkg/kubelet/cm/util:go_default_library",
+            "//pkg/kubelet/events:go_default_library",
+            "//pkg/kubelet/metrics:go_default_library",
+            "//pkg/kubelet/qos:go_default_library",
+            "//pkg/kubelet/stats/pidlimit:go_default_library",
+            "//pkg/kubelet/types:go_default_library",
             "//pkg/util/mount:go_default_library",
+            "//pkg/util/oom:go_default_library",
+            "//pkg/util/procfs:go_default_library",
+            "//pkg/util/sysctl:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/util/errors:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/util/runtime:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/util/version:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
             "//staging/src/k8s.io/client-go/tools/record:go_default_library",
+            "//vendor/github.com/docker/go-units:go_default_library",
+            "//vendor/github.com/opencontainers/runc/libcontainer/cgroups:go_default_library",
+            "//vendor/github.com/opencontainers/runc/libcontainer/cgroups/fs:go_default_library",
+            "//vendor/github.com/opencontainers/runc/libcontainer/cgroups/systemd:go_default_library",
+            "//vendor/github.com/opencontainers/runc/libcontainer/configs:go_default_library",
+            "//vendor/k8s.io/utils/io:go_default_library",
+            "//vendor/k8s.io/utils/path:go_default_library",
         ],
         "@io_bazel_rules_go//go/platform:darwin": [
             "//pkg/kubelet/cadvisor:go_default_library",
@@ -64,6 +89,11 @@ go_library(
             "//pkg/util/mount:go_default_library",
             "//staging/src/k8s.io/client-go/tools/record:go_default_library",
         ],
+        "@io_bazel_rules_go//go/platform:ios": [
+            "//pkg/kubelet/cadvisor:go_default_library",
+            "//pkg/util/mount:go_default_library",
+            "//staging/src/k8s.io/client-go/tools/record:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//pkg/api/v1/resource:go_default_library",
             "//pkg/apis/core/v1/helper:go_default_library",
@@ -140,6 +170,18 @@ go_test(
     ],
     embed = [":go_default_library"],
     deps = select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//pkg/features:go_default_library",
+            "//pkg/kubelet/eviction/api:go_default_library",
+            "//pkg/util/mount:go_default_library",
+            "//staging/src/k8s.io/api/core/v1:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/api/resource:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/types:go_default_library",
+            "//staging/src/k8s.io/apiserver/pkg/util/feature:go_default_library",
+            "//staging/src/k8s.io/component-base/featuregate/testing:go_default_library",
+            "//vendor/github.com/stretchr/testify/assert:go_default_library",
+            "//vendor/github.com/stretchr/testify/require:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//pkg/features:go_default_library",
             "//pkg/kubelet/eviction/api:go_default_library",

pkg/kubelet/cm/util/BUILD

@@ -13,6 +13,10 @@ go_library(
     ],
     importpath = "k8s.io/kubernetes/pkg/kubelet/cm/util",
     deps = select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//vendor/github.com/opencontainers/runc/libcontainer/cgroups:go_default_library",
+            "//vendor/github.com/opencontainers/runc/libcontainer/utils:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//vendor/github.com/opencontainers/runc/libcontainer/cgroups:go_default_library",
             "//vendor/github.com/opencontainers/runc/libcontainer/utils:go_default_library",

pkg/kubelet/config/BUILD

@@ -47,6 +47,10 @@ go_library(
         "//vendor/k8s.io/klog:go_default_library",
         "//vendor/k8s.io/utils/io:go_default_library",
     ] + select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//staging/src/k8s.io/client-go/util/flowcontrol:go_default_library",
+            "//vendor/github.com/fsnotify/fsnotify:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//staging/src/k8s.io/client-go/util/flowcontrol:go_default_library",
             "//vendor/github.com/fsnotify/fsnotify:go_default_library",
@@ -88,6 +92,9 @@ go_test(
         "//staging/src/k8s.io/client-go/util/testing:go_default_library",
         "//vendor/github.com/stretchr/testify/assert:go_default_library",
     ] + select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
         ],

pkg/kubelet/dockershim/BUILD

@@ -123,6 +123,9 @@ go_test(
         "//vendor/github.com/stretchr/testify/assert:go_default_library",
         "//vendor/github.com/stretchr/testify/require:go_default_library",
     ] + select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//staging/src/k8s.io/api/core/v1:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//staging/src/k8s.io/api/core/v1:go_default_library",
         ],

pkg/kubelet/dockershim/cm/BUILD

@@ -16,7 +16,14 @@ go_library(
     importpath = "k8s.io/kubernetes/pkg/kubelet/dockershim/cm",
     deps = select({
         "@io_bazel_rules_go//go/platform:android": [
+            "//pkg/kubelet/cm:go_default_library",
             "//pkg/kubelet/dockershim/libdocker:go_default_library",
+            "//pkg/kubelet/qos:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/util/version:go_default_library",
+            "//staging/src/k8s.io/apimachinery/pkg/util/wait:go_default_library",
+            "//vendor/github.com/opencontainers/runc/libcontainer/cgroups/fs:go_default_library",
+            "//vendor/github.com/opencontainers/runc/libcontainer/configs:go_default_library",
+            "//vendor/k8s.io/klog:go_default_library",
         ],
         "@io_bazel_rules_go//go/platform:darwin": [
             "//pkg/kubelet/dockershim/libdocker:go_default_library",
@@ -27,6 +34,9 @@ go_library(
         "@io_bazel_rules_go//go/platform:freebsd": [
             "//pkg/kubelet/dockershim/libdocker:go_default_library",
         ],
+        "@io_bazel_rules_go//go/platform:ios": [
+            "//pkg/kubelet/dockershim/libdocker:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//pkg/kubelet/cm:go_default_library",
             "//pkg/kubelet/dockershim/libdocker:go_default_library",

pkg/kubelet/dockershim/network/cni/BUILD

@@ -39,6 +39,23 @@ go_test(
     srcs = ["cni_test.go"],
     embed = [":go_default_library"],
     deps = select({
+        "@io_bazel_rules_go//go/platform:android": [
+            "//pkg/kubelet/apis/config:go_default_library",
+            "//pkg/kubelet/container:go_default_library",
+            "//pkg/kubelet/container/testing:go_default_library",
+            "//pkg/kubelet/dockershim/network:go_default_library",
+            "//pkg/kubelet/dockershim/network/cni/testing:go_default_library",
+            "//pkg/kubelet/dockershim/network/hostport:go_default_library",
+            "//pkg/kubelet/dockershim/network/testing:go_default_library",
+            "//staging/src/k8s.io/api/core/v1:go_default_library",
+            "//staging/src/k8s.io/client-go/kubernetes:go_default_library",
+            "//staging/src/k8s.io/client-go/util/testing:go_default_library",
+            "//vendor/github.com/containernetworking/cni/pkg/types/020:go_default_library",
+            "//vendor/github.com/stretchr/testify/mock:go_default_library",
+            "//vendor/github.com/stretchr/testify/require:go_default_library",
+            "//vendor/k8s.io/utils/exec:go_default_library",
+            "//vendor/k8s.io/utils/exec/testing:go_default_library",
+        ],
         "@io_bazel_rules_go//go/platform:linux": [
             "//pkg/kubelet/apis/config:go_default_library",
             "//pkg/kubelet/container:go_default_library",