Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docker_build_opts bound variable #82963

Merged
merged 2 commits into from Sep 25, 2019
Merged

fix docker_build_opts bound variable #82963

merged 2 commits into from Sep 25, 2019

Conversation

zouyee
Copy link
Member

@zouyee zouyee commented Sep 21, 2019 •
edited

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix docker_build_opts bound variable

Which issue(s) this PR fixes:

Fixes #82962

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 21, 2019
@zouyee
Copy link
Member Author

zouyee commented Sep 21, 2019

/cc @dims

@zouyee
Copy link
Member Author

zouyee commented Sep 21, 2019

/sig release

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 21, 2019
@zouyee
Copy link
Member Author

zouyee commented Sep 21, 2019

/cc @neolit123

@neolit123
Copy link
Member

@zouyee
please make sure the CI tests pass.

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from neolit123 September 21, 2019 17:40
@cblecker cblecker self-assigned this Sep 21, 2019
@zouyee
Copy link
Member Author

zouyee commented Sep 22, 2019

/retest

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2019
using echo to print args
8249e48 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2019
fix docker_build_opts bound variable
e88b81c 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 23, 2019 •
edited

@zouyee: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-conformance-kind-ipv6 f018b1277c10dda5a4b50cb3c12e456f6ac1c7f2 link /test pull-kubernetes-conformance-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zouyee
Copy link
Member Author

zouyee commented Sep 23, 2019

/test pull-kubernetes-integration

@zouyee
Copy link
Member Author

zouyee commented Sep 23, 2019

@cblecker PTAL

@zouyee
Copy link
Member Author

zouyee commented Sep 23, 2019

/cc @mikedanese

fejta
fejta reviewed Sep 24, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

build/lib/release.sh
# is set to y or Y; otherwise try to build the image without forcefully
# pulling the latest base image.
local DOCKER_BUILD_OPTS=()
if [[ "${KUBE_BUILD_PULL_LATEST_IMAGES}" =~ [yY] ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does something like this work?

if [[ pull == ~y ]]; then
  local -r docker_build_opts=(--pull)
else
  local -r docker_build_opts=()
fi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing, it does not work.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2019
@fejta
Copy link
Contributor

fejta commented Sep 25, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit fa1d4bb into kubernetes:master Sep 25, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@dims dims Awaiting requested review from dims

@cblecker cblecker Awaiting requested review from cblecker

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@fejta fejta

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

docker_build_opts bound variable
5 participants
@zouyee @neolit123 @k8s-ci-robot @fejta @cblecker