Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding owners for EndpointSlice controller #83079

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Adding owners for EndpointSlice controller #83079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions pkg/controller/endpointslice/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- bowei
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make more sense to add the sig-network-approvers alias as a backstop, and the sig-network-reviewers alias as a backstop for reviewers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks! Just pushed an update with those aliases added.

- freehan
- MrHohn
- thockin
- sig-network-approvers
reviewers:
- robscott
- freehan
- bowei
- sig-network-reviewers
labels:
- sig/network