Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set up additional, bigger nodes during tests #83352

Merged
merged 1 commit into from Oct 3, 2019
Merged

Ability to set up additional, bigger nodes during tests #83352

merged 1 commit into from Oct 3, 2019

Conversation

jkaniuk
Copy link
Contributor

@jkaniuk jkaniuk commented Oct 1, 2019

Network policy provider pods requests more than 1 core in 100+ nodes clusters.
kubernetes/test-infra#13709

/sig scalability
/cc mm4tt
/cc wojtek-t

What type of PR is this?
/kind feature

What this PR does / why we need it:
Network policy provider pods requests more than 1 core in 100+ nodes clusters.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 1, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jkaniuk. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Oct 1, 2019
@mborsz
Copy link
Member

mborsz commented Oct 1, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2019
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Oct 1, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Oct 1, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
mm4tt
mm4tt reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@mm4tt mm4tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but overall LGTM

cluster/gce/util.sh Outdated Show resolved Hide resolved
cluster/gce/util.sh Outdated Show resolved Hide resolved
cluster/gce/util.sh Outdated
"${ENABLE_IP_ALIASES:-}" \
"${IP_ALIAS_SIZE:-}")

for ((i=1; i<=${NUM_ADDITIONAL_NODES}; i++)); do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative would be to create a new instance-template from the already existing one and override only machine type and then create a MIG, but I'm not sure if it's possible to create an instance-template from another one.
Another advantage is that MIG will scale better if someone wants to have a big number of additional nodes (e.g. 500).

But overall, this looks good to me, it should work for our use case, so it's a good start. We can improve in future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think that we should create MIGs.

Also, I would really like to avoid such huge code duplication. Can't we reuse: "create-nodes-template" and "create-*-nodes" functions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewritten to use MIGs

@jkaniuk jkaniuk force-pushed the additional-nodes branch 3 times, most recently from 3e62e04 to 69455a4 Compare October 1, 2019 11:57
wojtek-t
wojtek-t reviewed Oct 1, 2019
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

cluster/gce/util.sh Outdated
"${ENABLE_IP_ALIASES:-}" \
"${IP_ALIAS_SIZE:-}")

for ((i=1; i<=${NUM_ADDITIONAL_NODES}; i++)); do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think that we should create MIGs.

Also, I would really like to avoid such huge code duplication. Can't we reuse: "create-nodes-template" and "create-*-nodes" functions?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 2, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2019
@jkaniuk
Copy link
Contributor Author

jkaniuk commented Oct 3, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

wojtek-t
wojtek-t reviewed Oct 3, 2019
View reviewed changes
cluster/gce/util.sh Outdated
fi

if [[ -n "${ADDITIONAL_MACHINE_TYPE:-}" && "${NUM_ADDITIONAL_NODES:-}" -gt 0 ]]; then
echo "Creating ${NUM_ADDITIONAL_NODES} special nodes with machine-type ${ADDITIONAL_MACHINE_TYPE}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: what if NUM_ADDITIONAL_NODES > NUM_NODES ?

@wojtek-t
Copy link
Member

wojtek-t commented Oct 3, 2019

/hold cancel

One minor comment

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2019
@wojtek-t wojtek-t self-assigned this Oct 3, 2019
@wojtek-t
Copy link
Member

wojtek-t commented Oct 3, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkaniuk, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 90f4871 into kubernetes:master Oct 3, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt mm4tt left review comments

@wojtek-t wojtek-t wojtek-t left review comments

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jkaniuk @k8s-ci-robot @mborsz @wojtek-t @mm4tt