Log results of each plugin in scheduler framework #83538

wgliang · 2019-10-06T05:33:38Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Log results of each plugin in scheduler framework

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

alculquicondor · 2019-10-07T14:14:42Z

/assign @liu-cong

pkg/scheduler/framework/v1alpha1/framework.go

pkg/scheduler/framework/v1alpha1/framework_test.go

liu-cong

Can you mark resolved comments as "Resolved"? Thanks!

pkg/scheduler/framework/v1alpha1/framework_test.go

wgliang · 2019-10-09T03:04:25Z

/test pull-kubernetes-e2e-gce

pkg/scheduler/framework/v1alpha1/framework.go

liu-cong · 2019-10-11T15:17:56Z

/lgtm

Thanks Leon!

/assign ahg-g

wgliang · 2019-10-12T12:50:15Z

/ping @ahg-g

wgliang · 2019-10-14T06:12:00Z

/priority important-soon

liu-cong · 2019-10-17T15:32:12Z

can you rebase

ahg-g

I put some 19 comments on this PR, I am very skeptical that this is going to be useful, logging for each pod for each node on each extension point is massive, even if it was enabled temporarily. I don' think this should be merged.

pkg/scheduler/framework/v1alpha1/framework.go

ahg-g · 2019-10-17T15:56:54Z

I put some 19 comments on this PR, I am very skeptical that this is going to be useful, logging for each pod for each node on each extension point is massive, even if it was enabled temporarily. I don' think this should be merged.

if we want more insights from logs, we can do that outside the framework: log a line after running all filters on all nodes for example.

k8s-ci-robot · 2019-10-21T09:46:45Z

New changes are detected. LGTM label has been removed.

wgliang · 2019-10-21T09:48:54Z

I put some 19 comments on this PR, I am very skeptical that this is going to be useful, logging for each pod for each node on each extension point is massive, even if it was enabled temporarily. I don' think this should be merged.

if we want more insights from logs, we can do that outside the framework: log a line after running all filters on all nodes for example.

@ahg-g Thanks for your review. I've updated and rebased it.

k8s-ci-robot · 2019-10-21T09:49:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wgliang
To complete the pull request process, please assign ahg-g
You can assign the PR to them by writing /assign @ahg-g in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/scheduler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wgliang · 2019-10-22T08:42:28Z

pkg/scheduler/framework/v1alpha1/framework_test.go

@@ -586,7 +594,7 @@ func TestRecordingMetrics(t *testing.T) {
 		},
 		{
 			name:               "Filter - Success",
-			action:             func(f Framework) { f.RunFilterPlugins(context.Background(), nil, pod, nil) },
+			action:             func(f Framework) { f.RunFilterPlugins(context.Background(), nil, pod, nodeInfo) },


This is to solve the panic issue(L346).

wgliang · 2019-10-22T08:47:36Z

pkg/scheduler/framework/v1alpha1/framework.go

-				errMsg := fmt.Sprintf("error while running %q filter plugin for pod %q: %v",
-					pl.Name(), pod.Name, status.Message())
+				errMsg := fmt.Sprintf("error while running %q filter plugin for pod %q on node %v: %v",
+					pl.Name(), pod.Name, nodeInfo.Node().Name, status.Message())


Print nodeInfo.Node().Name

fejta-bot · 2020-01-20T08:49:32Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

k8s-ci-robot · 2020-01-20T08:49:40Z

@wgliang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2020-02-19T09:32:02Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2020-03-20T10:16:14Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2020-03-20T10:16:22Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from alculquicondor and hex108 October 6, 2019 05:34

wgliang force-pushed the cleanup/log-each-plugins branch 2 times, most recently from 86b7400 to 174225a Compare October 7, 2019 03:47

k8s-ci-robot assigned liu-cong Oct 7, 2019

liu-cong reviewed Oct 7, 2019

View reviewed changes

wgliang force-pushed the cleanup/log-each-plugins branch 3 times, most recently from 3932452 to 32cb44a Compare October 8, 2019 06:19

liu-cong reviewed Oct 8, 2019

View reviewed changes

pkg/scheduler/framework/v1alpha1/framework_test.go Outdated Show resolved Hide resolved

wgliang force-pushed the cleanup/log-each-plugins branch from 32cb44a to 867ca43 Compare October 9, 2019 02:01

liu-cong reviewed Oct 9, 2019

View reviewed changes

wgliang force-pushed the cleanup/log-each-plugins branch 3 times, most recently from 7fb50d3 to 63fe2a5 Compare October 11, 2019 02:48

k8s-ci-robot assigned ahg-g Oct 11, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2019

k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 14, 2019

ahg-g reviewed Oct 17, 2019

View reviewed changes

wgliang added 2 commits October 21, 2019 17:45

Log results of each plugin in scheduler framework

a2d282c

fix RunPreFilter panic error when pod is nil

b4bc9c8

wgliang force-pushed the cleanup/log-each-plugins branch from 63fe2a5 to b4bc9c8 Compare October 21, 2019 09:46

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2019

wgliang commented Oct 22, 2019

View reviewed changes

k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 20, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 19, 2020

k8s-ci-robot closed this Mar 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Log results of each plugin in scheduler framework #83538

Log results of each plugin in scheduler framework #83538

wgliang commented Oct 6, 2019

alculquicondor commented Oct 7, 2019

liu-cong left a comment

wgliang commented Oct 9, 2019

liu-cong commented Oct 11, 2019

wgliang commented Oct 12, 2019

wgliang commented Oct 14, 2019

liu-cong commented Oct 17, 2019

ahg-g left a comment

ahg-g commented Oct 17, 2019

k8s-ci-robot commented Oct 21, 2019

wgliang commented Oct 21, 2019

k8s-ci-robot commented Oct 21, 2019

wgliang Oct 22, 2019 •

edited

wgliang Oct 22, 2019

fejta-bot commented Jan 20, 2020

k8s-ci-robot commented Jan 20, 2020

fejta-bot commented Feb 19, 2020

fejta-bot commented Mar 20, 2020

k8s-ci-robot commented Mar 20, 2020

Log results of each plugin in scheduler framework #83538

Log results of each plugin in scheduler framework #83538

Conversation

wgliang commented Oct 6, 2019

alculquicondor commented Oct 7, 2019

liu-cong left a comment

Choose a reason for hiding this comment

wgliang commented Oct 9, 2019

liu-cong commented Oct 11, 2019

wgliang commented Oct 12, 2019

wgliang commented Oct 14, 2019

liu-cong commented Oct 17, 2019

ahg-g left a comment

Choose a reason for hiding this comment

ahg-g commented Oct 17, 2019

k8s-ci-robot commented Oct 21, 2019

wgliang commented Oct 21, 2019

k8s-ci-robot commented Oct 21, 2019

wgliang Oct 22, 2019 • edited

Choose a reason for hiding this comment

wgliang Oct 22, 2019

Choose a reason for hiding this comment

fejta-bot commented Jan 20, 2020

k8s-ci-robot commented Jan 20, 2020

fejta-bot commented Feb 19, 2020

fejta-bot commented Mar 20, 2020

k8s-ci-robot commented Mar 20, 2020

wgliang Oct 22, 2019 •

edited