New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle error return if portString parsing has error #83871
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tedyu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-integration |
Hi, @tedyu looks like etcdUrl.Host not contains colon will have null port and address now |
yeah, if the |
@aojea @whs-dot-hk |
Yes, it looks fine now but I am not a member of kubernetes to approve |
/assign @liggitt |
Thanks for the PR, but https://github.com/kubernetes/kubernetes/pull/82680/files#diff-e735088e40a414f069432ee1deacd83eR361 is already open sweeping all strconv use for port parsing |
/close |
@liggitt: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
In componentStatusStorage#serversToValidate, the error return from strconv.Atoi is ignored.
When portString parsing has error, we should handle it.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: