Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove CheckNodeMemoryPressure/DiskPressure/PIDPressure/Condition #84152

Merged
merged 1 commit into from Oct 22, 2019
Merged

feat: remove CheckNodeMemoryPressure/DiskPressure/PIDPressure/Condition #84152

merged 1 commit into from Oct 22, 2019

Conversation

draveness
Copy link
Contributor

@draveness draveness commented Oct 21, 2019 •
edited

/kind cleanup
/sig scheduling
/assign @ahg-g

What this PR does / why we need it:

TaintNodesByCondition was graduated to the stable version, and the following predicates have been disabled by default since 1.12. We could remove them:

  • CheckNodeMemoryPressure
  • CheckNodeDiskPressure
  • CheckNodePIDPressure
  • CheckNodeCondition

Which issue(s) this PR fixes:

Fixes #84100

Does this PR introduce a user-facing change?:

TaintNodesByCondition was graduated to GA, CheckNodeMemoryPressure, CheckNodePIDPressure, CheckNodeDiskPressure, CheckNodeCondition were accidentally removed since 1.12, the replacement is to use CheckNodeUnschedulablePred

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 21, 2019
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 21, 2019
@draveness draveness force-pushed the feature/remove-node-memory-predicate branch from 890cd6d to b2b050e Compare October 21, 2019 10:20
@draveness
Copy link
Contributor Author

/kind cleanup
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 21, 2019
@draveness draveness force-pushed the feature/remove-node-memory-predicate branch from b2b050e to fdeebf7 Compare October 21, 2019 10:51
@ahg-g
Copy link
Member

ahg-g commented Oct 21, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 21, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 21, 2019

/approve cancel
/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 21, 2019

/approve
/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 21, 2019
@ahg-g
Copy link
Member

ahg-g commented Oct 21, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, draveness

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2019
@draveness
Copy link
Contributor Author

/retest

@ahg-g
Copy link
Member

ahg-g commented Oct 21, 2019

Does this PR introduce a user-facing change?:

TaintNodesByCondition was graduated to GA, CheckNodeMemoryPressure, CheckNodePIDPressure, CheckNodeDiskPressure, CheckNodeCondition predicates was removed.

Please add that "CheckNodeMemoryPressure, CheckNodePIDPressure, CheckNodeDiskPressure, CheckNodeCondition were accidentally removed since 1.12, the replacement is to use CheckNodeUnschedulablePred"

@ahg-g
Copy link
Member

ahg-g commented Oct 21, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@draveness
Copy link
Contributor Author

draveness commented Oct 22, 2019 via email

@draveness draveness force-pushed the feature/remove-node-memory-predicate branch from fdeebf7 to c694494 Compare October 22, 2019 07:18
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 22, 2019
@draveness draveness force-pushed the feature/remove-node-memory-predicate branch from cbd9d56 to 09f3339 Compare October 22, 2019 07:28
@ahg-g
Copy link
Member

ahg-g commented Oct 22, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 97c7ccc into kubernetes:master Oct 22, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 22, 2019
@kasturinarra kasturinarra mentioned this pull request Jan 24, 2020
Closed
@tanjing2020 tanjing2020 mentioned this pull request Feb 24, 2021
Closed
@AthinaKyriakou
Copy link

Shouldn't the documentation be updated too?

@draveness draveness deleted the feature/remove-node-memory-predicate branch May 7, 2021 10:32
@draveness draveness mentioned this pull request May 7, 2021
Merged
@draveness
Copy link
Contributor Author

Shouldn't the documentation be updated too?

fair enough, create a pull request against website kubernetes/website#27903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@wgliang wgliang Awaiting requested review from wgliang

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

[scheduler] Cleanup CheckNodeMemoryPressure/DiskPressure/PIDPressure/Condition predicates
5 participants
@draveness @ahg-g @k8s-ci-robot @fejta-bot @AthinaKyriakou