Support glob wildcards for gcr.io credentials #8438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @brendanburns do you have updates on this PR? thanks! |
| if err != nil { | ||
| return false, err | ||
| } | ||
| return urlMatched_(globUrl, targetUrl) |
There was a problem hiding this comment.
please remove the underscore.
|
minor comments and needs a rebase. |
tcnghia
force-pushed
the
master
branch
3 times, most recently
from
48399a9
to
a74c0ce
Compare
|
LGTM. |
brendandburns
added
the
lgtm
rjnagal
added a commit
that referenced
this pull request
May 29, 2015
Support glob wildcards for gcr.io credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding glob wildcards to URLs for GCR.IO credentials.
Globs were chosen instead of regular expression because we prefer clarity and globs would serve most of our use cases well already.