Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Use a better filter on find #84761

Merged
merged 1 commit into from Nov 5, 2019
Merged

Build: Use a better filter on find #84761

merged 1 commit into from Nov 5, 2019

Conversation

thockin
Copy link
Member

@thockin thockin commented Nov 5, 2019

/kind bug

What this PR does / why we need it:

The build can hit "args too long" errors if we don't filter properly.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2019
@thockin thockin added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 5, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@thockin
Copy link
Member Author

thockin commented Nov 5, 2019

Sadly, this now breaks _examples that actually want codegen to run. Grrrr.

@thockin
Copy link
Member Author

thockin commented Nov 5, 2019

Re-pushed. Keeping the simpler filters, just excluding Gopath now. I don't know what the hack/update-workspace-mirror.sh is for, but it leaves a mess.

@thockin
Build: Use a better filter on find
a1ad491 
In case the _workspace directory exists, filter it out.
@liggitt
Copy link
Member

liggitt commented Nov 5, 2019

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2019
@gerred
Copy link

gerred commented Nov 5, 2019

/area conformance

@k8s-ci-robot k8s-ci-robot added the area/conformance Issues or PRs related to kubernetes conformance tests label Nov 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8245a24 into kubernetes:master Nov 5, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 5, 2019
@thockin thockin deleted the make-better-find-filter branch August 2, 2021 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@ixdy ixdy Awaiting requested review from ixdy

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thockin @k8s-ci-robot @liggitt @gerred