Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose PredicateMetadataProducer in generic scheduler #84785

Merged
merged 1 commit into from Nov 5, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/scheduler/core/generic_scheduler.go
Expand Up @@ -131,6 +131,10 @@ type ScheduleAlgorithm interface {
// Extenders returns a slice of extender config. This is exposed for
// testing.
Extenders() []algorithm.SchedulerExtender
// GetPredicateMetadataProducer returns the predicate metadata producer. This is needed
// for cluster autoscaler integration.
// TODO(ahg-g): remove this once CA migrates to creating a Framework instead of a full scheduler.
PredicateMetadataProducer() predicates.PredicateMetadataProducer
}

// ScheduleResult represents the result of one pod scheduled. It will contain
Expand Down Expand Up @@ -171,6 +175,13 @@ func (g *genericScheduler) snapshot() error {
return g.cache.UpdateNodeInfoSnapshot(g.nodeInfoSnapshot)
}

// GetPredicateMetadataProducer returns the predicate metadata producer. This is needed
// for cluster autoscaler integration.
func (g *genericScheduler) PredicateMetadataProducer() predicates.PredicateMetadataProducer {
return g.predicateMetaProducer

}

// Schedule tries to schedule the given pod to one of the nodes in the node list.
// If it succeeds, it will return the name of the node.
// If it fails, it will return a FitError error with reasons.
Expand Down
5 changes: 5 additions & 0 deletions pkg/scheduler/scheduler_test.go
Expand Up @@ -152,6 +152,11 @@ type mockScheduler struct {
err error
}

func (es mockScheduler) PredicateMetadataProducer() predicates.PredicateMetadataProducer {
return nil

}

func (es mockScheduler) Schedule(ctx context.Context, state *framework.CycleState, pod *v1.Pod) (core.ScheduleResult, error) {
return es.result, es.err
}
Expand Down