Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: promote CRD defaulting test to conformance test #84861

Merged
merged 1 commit into from Nov 16, 2019
Merged

e2e: promote CRD defaulting test to conformance test #84861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions test/conformance/testdata/conformance.txt
View file
Open in desktop
Expand Up @@ -15,6 +15,7 @@ test/e2e/apimachinery/custom_resource_definition.go: "creating/deleting custom r
test/e2e/apimachinery/custom_resource_definition.go: "listing custom resource definition objects works"
test/e2e/apimachinery/custom_resource_definition.go: "getting/updating/patching custom resource definition status sub-resource works"
test/e2e/apimachinery/custom_resource_definition.go: "should include custom resource definition resources in discovery documents"
test/e2e/apimachinery/custom_resource_definition.go: "custom resource defaulting for requests and from storage works"
test/e2e/apimachinery/garbage_collector.go: "should delete pods created by rc when not orphaning"
test/e2e/apimachinery/garbage_collector.go: "should orphan pods created by rc if delete options say so"
test/e2e/apimachinery/garbage_collector.go: "should delete RS created by deployment when not orphaning"
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/apimachinery/custom_resource_definition.go
View file
Open in desktop
Expand Up @@ -264,7 +264,7 @@ var _ = SIGDescribe("CustomResourceDefinition resources [Privileged:ClusterAdmin
the default is applied. Create another CR. Remove default, add default for another field and read CR until
new field is defaulted, but old default stays.
*/
ginkgo.It("custom resource defaulting for requests and from storage works ", func() {
framework.ConformanceIt("custom resource defaulting for requests and from storage works ", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a new test it needs to be added as an e2e and soak for a bit before we promote it (can't be flaky). are there any existing e2e tests for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest a separate PR that adds this as an e2e test that uses the beta API. That way we get a signal on flakiness. then the PR to promote to GA would only promote, not implement that test

config, err := framework.LoadConfig()
framework.ExpectNoError(err, "loading config")
apiExtensionClient, err := clientset.NewForConfig(config)
Expand Down