Fix setting resource isolation in Docker 1.6+ #8491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for new Docker remote API.
|
Ran e2e, all tests pass! Verified shares are set manually. |
|
Thanks for the fix. LGTM except one nit. :-) |
This allows for backwards and forwards compatability since old Docker versions expect it in Create() and newer ones do so in Start(). Fixes kubernetes#8358
|
LGTM |
dchen1107
added a commit
that referenced
this pull request
May 19, 2015
Fix setting resource isolation in Docker 1.6+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates go-dockerclient and sets resource isolation parameters in Create() and Start().
/cc @dchen1107
Will run e2e tomorrow.