Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental]: instrument etcd request/response object sizes #85021

Closed
wants to merge 4 commits into from

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Nov 9, 2019

Experimentally adding metrics and logging of etcd object sizes in requests and responses, broken out by operation and k8s type.

Using this in the short term to inspect server side apply performance.

/kind feature

TODO

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2019
@jpbetz jpbetz changed the title DO-NOT-MERGE: instrument etcd request/response object sizes [do not merge]: instrument etcd request/response object sizes Nov 9, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2019
@jpbetz jpbetz changed the title [do not merge]: instrument etcd request/response object sizes [experimental]: instrument etcd request/response object sizes Nov 9, 2019
@apelisse
Copy link
Member

The tests have run, how do you plan on looking at these results?

@apelisse
Copy link
Member

Also, to trigger the actual thing that we want to test, we have to apply the following diff:
https://github.com/kubernetes/kubernetes/pull/84870/files#diff-438c18fccd3899026928547522f80743

@apelisse
Copy link
Member

apelisse commented Nov 14, 2019

You also needs something like this to make sure that SSA is enabled on all requests:

diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/fieldmanager.go b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/fieldmanager.go
index 3f2b08984ea..a670ee053a9 100644
--- a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/fieldmanager.go
+++ b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/fieldmanager.go
@@ -92,7 +92,7 @@ func newDefaultFieldManager(f Manager, objectCreater runtime.ObjectCreater, kind
        f = NewStripMetaManager(f)
        f = NewBuildManagerInfoManager(f, kind.GroupVersion())
        f = NewCapManagersManager(f, DefaultMaxUpdateManagers)
-       f = NewSkipNonAppliedManager(f, objectCreater, kind)
+       //      f = NewSkipNonAppliedManager(f, objectCreater, kind)
        return NewFieldManager(f)
 }

OK, I actually said that actually :-)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jpbetz
To complete the pull request process, please assign xiang90
You can assign the PR to them by writing /assign @xiang90 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 15, 2019

@jpbetz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-verify baacaea link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jpbetz jpbetz closed this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants