Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps CoreDNS to 1.6.5 and updates manifest for kube-up #85109

Merged
merged 1 commit into from Nov 13, 2019
Merged

Bumps CoreDNS to 1.6.5 and updates manifest for kube-up #85109

merged 1 commit into from Nov 13, 2019

Conversation

rajansandeep
Copy link
Contributor

@rajansandeep rajansandeep commented Nov 11, 2019 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Bumps the CoreDNS version to 1.6.5
  • Updates the corefile-migration library to v1.0.4 which includes migration support up to CoreDNS v1.6.5

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
This PR is dependent on the CoreDNS 1.6.5 image be pushed to gcr.io for which #84993 has been opened.

/hold

Does this PR introduce a user-facing change?:

Kubeadm now includes CoreDNS version 1.6.5
 - `kubernetes` plugin adds metrics to measure kubernetes control plane latency.
 -  the `health` plugin now includes the `lameduck` option by default, which waits for a duration before shutting down.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 11, 2019
@rajansandeep
Copy link
Contributor Author

/assign @BenTheElder @bowei @MrHohn

MrHohn
MrHohn reviewed Nov 11, 2019
View reviewed changes
cluster/addons/dns/coredns/coredns.yaml.base Outdated
@@ -114,9 +116,18 @@ spec:
operator: "Exists"
nodeSelector:
beta.kubernetes.io/os: linux
affinity:
podAntiAffinity:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the performance issue (e.g. #54164) on larger cluster been resolved yet?
/cc @wojtek-t

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahg-g - for thoughts
There were some improvements, but I don't know if it's good enough already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the pod anti-affinity changes from this PR.
Once the manual scale tests by @oxddr in #84733 are complete, I will include the anti-affinity changes in a separate PR.

@rajansandeep
Copy link
Contributor Author

/hold cancel
Since the image seems to have been pushed to gcr

/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2019
@wojtek-t
Copy link
Member

/assign @oxddr
As he was doing some performance evaluation of the new image.

@oxddr
Copy link
Contributor

oxddr commented Nov 12, 2019

I've only just kicked tests - I had an unrelated issue with building Kubernetes.

@oxddr
Copy link
Contributor

oxddr commented Nov 13, 2019

/lgtm
from scalability perspective - I've tested #84733 against 5k node cluster and results looks good: tests passed and SLIs looked comparable to other good runs.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2019
@rajansandeep
Copy link
Contributor Author

/priority important-soon
/retest
/cc @bowei @MrHohn @BenTheElder

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 13, 2019
@chrisohaver
Copy link
Contributor

/test pull-kubernetes-node-e2e-containerd

MrHohn
MrHohn approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@BenTheElder
Copy link
Member

/approve
for build/

@wojtek-t
Copy link
Member

/lgtm
/approve

For cluster/ and others too.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, MrHohn, rajansandeep, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@rajansandeep
Copy link
Contributor Author

/test pull-kubernetes-node-e2e-containerd

@k8s-ci-robot k8s-ci-robot merged commit d0f0215 into kubernetes:master Nov 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@jingax10 jingax10 Awaiting requested review from jingax10

@lavalamp lavalamp Awaiting requested review from lavalamp

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@bowei bowei Awaiting requested review from bowei

Assignees

@bowei bowei

@BenTheElder BenTheElder

@MrHohn MrHohn

@wojtek-t wojtek-t

@oxddr oxddr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rajansandeep @wojtek-t @oxddr @chrisohaver @BenTheElder @k8s-ci-robot @MrHohn @bowei