Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote VolumeSubpathEnvExpansion e2e tests to Conformance #85128

Merged
merged 1 commit into from Mar 23, 2020
Merged

Promote VolumeSubpathEnvExpansion e2e tests to Conformance #85128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
44 changes: 44 additions & 0 deletions test/conformance/testdata/conformance.yaml
View file
Open in desktop
Expand Up @@ -410,6 +410,50 @@
proper values.
release: v1.9
file: test/e2e/common/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath expansion
codename: '[k8s.io] Variable Expansion should allow substituting values in a volume
subpath [sig-storage] [Conformance]'
description: Make sure a container's subpath can be set using an expansion of environment
variables.
release: v1.19
file: test/e2e/common/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath with absolute path
codename: '[k8s.io] Variable Expansion should fail substituting values in a volume
subpath with absolute path [sig-storage][Slow] [Conformance]'
description: Make sure a container's subpath can not be set using an expansion of
environment variables when absolute path is supplied.
release: v1.19
file: test/e2e/common/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath with backticks
codename: '[k8s.io] Variable Expansion should fail substituting values in a volume
subpath with backticks [sig-storage][Slow] [Conformance]'
description: Make sure a container's subpath can not be set using an expansion of
environment variables when backticks are supplied.
release: v1.19
file: test/e2e/common/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath lifecycle
codename: '[k8s.io] Variable Expansion should not change the subpath mount on a
container restart if the environment variable changes [sig-storage][Slow] [Conformance]'
description: "Verify should not change the subpath mount on a container restart
if the environment variable changes 1.\tvalid subpathexpr starts a container running
2.\ttest for valid subpath writes 3.\tcontainer restarts 4.\tdelete cleanly"
release: v1.19
file: test/e2e/common/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath test writes
codename: '[k8s.io] Variable Expansion should succeed in writing subpaths in container
[sig-storage][Slow] [Conformance]'
description: "Verify that a subpath expansion can be used to write files into subpaths.
1.\tvalid subpathexpr starts a container running 2.\ttest for valid subpath writes
3.\tsuccessful expansion of the subpathexpr isn't required for volume cleanup"
release: v1.19
file: test/e2e/common/expansion.go
- testname: VolumeSubpathEnvExpansion, subpath ready from failed state
codename: '[k8s.io] Variable Expansion should verify that a failing subpath expansion
can be modified during the lifecycle of a container [sig-storage][Slow] [Conformance]'
description: Verify that a failing subpath expansion can be modified during the
lifecycle of a container.
release: v1.19
file: test/e2e/common/expansion.go
- testname: Pod events, verify event from Scheduler and Kubelet
codename: '[k8s.io] [sig-node] Events should be sent by kubelets and the scheduler
about pods scheduling and running [Conformance]'
Expand Down
60 changes: 31 additions & 29 deletions test/e2e/common/expansion.go
View file
Open in desktop
Expand Up @@ -155,11 +155,11 @@ var _ = framework.KubeDescribe("Variable Expansion", func() {
})

/*
Testname: var-expansion-subpath
Description: Make sure a container's subpath can be set using an
expansion of environment variables.
Release : v1.19
Testname: VolumeSubpathEnvExpansion, subpath expansion
Description: Make sure a container's subpath can be set using an expansion of environment variables.
*/
ginkgo.It("should allow substituting values in a volume subpath [sig-storage]", func() {
framework.ConformanceIt("should allow substituting values in a volume subpath [sig-storage]", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! I think we'll need to do this as a two-step process. 1) Update to emptydir. 2) Once we verify it's stable and not flaky, then promote to conformance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have raised a separate Issue #87810 and will hold this one for the moment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msau42 Haven't seen any errors in sig testgrid since the HostPath change, so I would guess we're good to go with this one now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anywhere obvious in the PR tests that has actually performed the conformance prior to merge. Is there any easy way of checking that this PR did some Conformance e2e?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that this one pull-kubernetes-conformance-kind-ipv6-parallel has performed all 6 conformance tests, so that seems to confirm they are okay

podName := "var-expansion-" + string(uuid.NewUUID())
pod := &v1.Pod{
ObjectMeta: metav1.ObjectMeta{
Expand Down Expand Up @@ -209,11 +209,11 @@ var _ = framework.KubeDescribe("Variable Expansion", func() {
})

/*
Testname: var-expansion-subpath-with-backticks
Description: Make sure a container's subpath can not be set using an
expansion of environment variables when backticks are supplied.
Release : v1.19
Testname: VolumeSubpathEnvExpansion, subpath with backticks
Description: Make sure a container's subpath can not be set using an expansion of environment variables when backticks are supplied.
*/
ginkgo.It("should fail substituting values in a volume subpath with backticks [sig-storage][Slow]", func() {
framework.ConformanceIt("should fail substituting values in a volume subpath with backticks [sig-storage][Slow]", func() {

podName := "var-expansion-" + string(uuid.NewUUID())
pod := &v1.Pod{
Expand Down Expand Up @@ -258,11 +258,11 @@ var _ = framework.KubeDescribe("Variable Expansion", func() {
})

/*
Testname: var-expansion-subpath-with-absolute-path
Description: Make sure a container's subpath can not be set using an
expansion of environment variables when absolute path is supplied.
Release : v1.19
Testname: VolumeSubpathEnvExpansion, subpath with absolute path
Description: Make sure a container's subpath can not be set using an expansion of environment variables when absolute path is supplied.
*/
ginkgo.It("should fail substituting values in a volume subpath with absolute path [sig-storage][Slow]", func() {
framework.ConformanceIt("should fail substituting values in a volume subpath with absolute path [sig-storage][Slow]", func() {

podName := "var-expansion-" + string(uuid.NewUUID())
pod := &v1.Pod{
Expand Down Expand Up @@ -307,10 +307,11 @@ var _ = framework.KubeDescribe("Variable Expansion", func() {
})

/*
Testname: var-expansion-subpath-ready-from-failed-state
Description: Verify that a failing subpath expansion can be modified during the lifecycle of a container.
Release : v1.19
Testname: VolumeSubpathEnvExpansion, subpath ready from failed state
Description: Verify that a failing subpath expansion can be modified during the lifecycle of a container.
*/
ginkgo.It("should verify that a failing subpath expansion can be modified during the lifecycle of a container [sig-storage][Slow]", func() {
framework.ConformanceIt("should verify that a failing subpath expansion can be modified during the lifecycle of a container [sig-storage][Slow]", func() {

podName := "var-expansion-" + string(uuid.NewUUID())
containerName := "dapi-container"
Expand Down Expand Up @@ -387,14 +388,15 @@ var _ = framework.KubeDescribe("Variable Expansion", func() {
})

/*
Testname: var-expansion-subpath-test-writes
Description: Verify that a subpath expansion can be used to write files into subpaths.
1. valid subpathexpr starts a container running
2. test for valid subpath writes
3. successful expansion of the subpathexpr isn't required for volume cleanup
Release : v1.19
Testname: VolumeSubpathEnvExpansion, subpath test writes
Description: Verify that a subpath expansion can be used to write files into subpaths.
1. valid subpathexpr starts a container running
2. test for valid subpath writes
3. successful expansion of the subpathexpr isn't required for volume cleanup

*/
ginkgo.It("should succeed in writing subpaths in container [sig-storage][Slow]", func() {
framework.ConformanceIt("should succeed in writing subpaths in container [sig-storage][Slow]", func() {

podName := "var-expansion-" + string(uuid.NewUUID())
containerName := "dapi-container"
Expand Down Expand Up @@ -487,16 +489,16 @@ var _ = framework.KubeDescribe("Variable Expansion", func() {
})

/*
Testname: var-expansion-subpath-lifecycle
Description: Verify should not change the subpath mount on a container restart if the environment variable changes
1. valid subpathexpr starts a container running
2. test for valid subpath writes
3. container restarts
4. delete cleanly

Release : v1.19
Testname: VolumeSubpathEnvExpansion, subpath lifecycle
Description: Verify should not change the subpath mount on a container restart if the environment variable changes
1. valid subpathexpr starts a container running
2. test for valid subpath writes
3. container restarts
4. delete cleanly
*/

ginkgo.It("should not change the subpath mount on a container restart if the environment variable changes [sig-storage][Slow]", func() {
framework.ConformanceIt("should not change the subpath mount on a container restart if the environment variable changes [sig-storage][Slow]", func() {

suffix := string(uuid.NewUUID())
podName := fmt.Sprintf("var-expansion-%s", suffix)
Expand Down