New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add johnbelamaric as conformance code reviewer/approver #85154
Add johnbelamaric as conformance code reviewer/approver #85154
Conversation
/priority important-soon |
/retest |
approvers: | ||
- cheftako | ||
- spiffxp | ||
- johnbelamaric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On 8ee8b77#diff-fcbdff38f489e333841efa50e8f641f5 @spiffxp took a steady step to an approver from a reviewer.
I am not sure this approver promotion in a single PR according to the above PR.
@@ -4,9 +4,11 @@ | |||
reviewers: | |||
- cheftako | |||
- oomichi | |||
- johnbelamaric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 :-)
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, johnbelamaric, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Adds johnbelamaric as an approver of conformance code.
Which issue(s) this PR fixes:
Special notes for your reviewer:
I am currently an owner of the conformance sub-project and an approver for conformance tests. As we evolve the conformance code pursuant to this KEP, I will need to review and approve code changes in this area.
Does this PR introduce a user-facing change?: