update docs/volumes.md to v1beta3 #8547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,17 +3,17 @@ This document describes the current state of Volumes in kubernetes. Familiarity | |||
|
|
|||
| A Volume is a directory, possibly with some data in it, which is accessible to a Container. Kubernetes Volumes are similar to but not the same as [Docker Volumes](https://docs.docker.com/userguide/dockervolumes/). | |||
|
|
|||
| A Pod specifies which Volumes its containers need in its [ContainerManifest](https://developers.google.com/compute/docs/containers/container_vms#container_manifest) property. | |||
| A Pod specifies which Volumes its containers need in its [spec.volumes](http://kubernetes.io/third_party/swagger-ui/#!/v1beta3/createPod) property. | |||
There was a problem hiding this comment.
It's not spec.volumes but spec.containers[*].volumes
There was a problem hiding this comment.
No, it is spec.volumes. The doc also mentions the container's VolumeMounts property in the next paragraph.
Btw, is there any better place we can point people to other than the swagger-ui? swagger-ui currently takes very long time to load.
There was a problem hiding this comment.
It will be somewhat faster once we delete v1beta1 and v1beta2.
also update some details in the doc
|
Thanks @thockin. I've addressed your comments. Please take a look. We can add a section for persistent volumes in the future. |
bgrant0607
added
the
lgtm
|
LGTM |
|
Merging to shrink the backlog. |
lavalamp
added a commit
that referenced
this pull request
May 24, 2015
update docs/volumes.md to v1beta3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update docs/volumes.md to v1beta3； also update some details in the doc
@erictune @thockin @nikhiljindal
ref #8087