Change v1 API to default RC replicas to 1

[thockin]

Fixes #6700
Part of #7018

[thockin]

@bgrant0607 - chipping away at v1 nits

[bgrant0607]

LGTM. Thanks much.
cc @rjnagal

[rjnagal]

Thanks @thockin. I was just trying to sent this out over bad conf wifi.

The test failure is real but looks unrelated:

[rjnagal]

ok github.com/GoogleCloudPlatform/kubernetes/pkg/securitycontext 0.045s coverage: 62.5% of statements
--- FAIL: TestNoManualChangesToGenerateConversions (0.54s)
conversion_generation_test.go:129: please update conversion functions; generated: v1.functions.txt; first diff:
expected: func convert_api_AWSElasticBlockStoreVolumeSource_To_v1_AWSElasticBlockStoreVolumeSource(in *api.AWSElasticBlockStoreVolumeSource, out *AWSElasticBlockStoreVolumeSource, s conversion.Scope) error {

         got: func convert_v1_AWSElasticBlockStoreVolumeSource_To_api_AWSElasticBlockStoreVolumeSource(in *AWSElasticBlockStoreVolumeSource, out *api.AWSElasticBlockStoreVolumeSource, s conversion.Scope) error {

FAIL

[thockin]

Sorry, didn't know you were on it.

'make test' passes here. weird.

[thockin]

rebased, let's see if that helps. It looks like it is complaining that the generated code is in a different order, but it passes on my desktop.

@wojtek-t is the conversion code maybe using a map somewhere?

[wojtek-t]

this is strange - the code is supposed to sort the result:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/runtime/conversion_generator.go#L243

[thockin]

Failed again:

--- FAIL: TestNoManualChangesToGenerateConversions (0.70s)
    conversion_generation_test.go:129: please update conversion functions; generated: v1.functions.txt; first diff: 
        expected: func convert_api_ObjectReference_To_v1_ObjectReference(in *api.ObjectReference, out *ObjectReference, s conversion.Scope) error {

             got: func convert_v1_ObjectReference_To_api_ObjectReference(in *ObjectReference, out *api.ObjectReference, s conversion.Scope) error {

I can not repro - it passes locally.

[wojtek-t]

@thockin: I think the sorting function doesn't make sense (i.e. it's not deterministic). I will create a PR today to fix it).

[wojtek-t]

@thockin #8577 that should fix your problems is out for review

[dchen1107]

@thockin you have to rebase now. :-(

[thockin]

rebased

[dchen1107]

@thockin you have to rebase again. Sorry for this.

[thockin]

rebased again

[dchen1107]

We had e2e failures again after clean some backlogs for last two days. I am looking into those failures, and will merge this one first.

[thockin]

No worries.

On Thu, May 21, 2015 at 1:07 PM, Dawn Chen notifications@github.com wrote:

We had e2e failures again after clean some backlogs for last two days. I
am looking into those failures, and will merge this one first.

—
Reply to this email directly or view it on GitHub
#8552 (comment)
.

[thockin]

green and mergable :)

[rjnagal]

LGTM.

Oncall will merge when the door opens :)

[dchen1107]

Yes, sorry for postponing on this. Merging...