Run Docker containers as top-level containers in Debian. #8586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wish there was a way to single out GKE from Debian, as Debian has systemd enabled in the latest version. Looking around ... |
vmarmol
force-pushed
the
use-root-containers
branch
from
6a47489
to
959b434
Compare
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain @ixdy. |
vmarmol
force-pushed
the
use-root-containers
branch
from
959b434
to
0e242cd
Compare
|
ok to test |
|
PTAL @rjnagal this is ready to go I believe. We can improve the OS family detection later. I will also try to get the necessary changes into Docker 1.7. |
|
ok, let's go with this for now. LGTM |
rjnagal
added
the
lgtm
|
@vmarmol sorry about you have to rebase it again. |
vmarmol
force-pushed
the
use-root-containers
branch
from
0e242cd
to
656be14
Compare
|
@dchen1107 no worries! Rebased and re-pushed. |
|
I kicked out shippable for you again. |
saad-ali
added a commit
that referenced
this pull request
May 27, 2015
Run Docker containers as top-level containers in Debian.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue for GCE/GKE, I'll work on libcontainer/Docker changes to fix overall.
Part of #8215
/cc @rjnagal @dchen1107
Ran e2e and the run came back green!