Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #85847: Deflake pod readiness e2e #85860

Merged
merged 1 commit into from Dec 5, 2019
Merged

Automated cherry pick of #85847: Deflake pod readiness e2e #85860

merged 1 commit into from Dec 5, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Dec 3, 2019

Cherry pick of #85847 on release-1.17.

#85847: Deflake pod readiness e2e

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Dec 3, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 3, 2019
@liggitt
Copy link
Member Author

liggitt commented Dec 3, 2019

picked to release-1.17 to improve CI signal, non release-blocking, can go into 1.17.1

@liggitt
Copy link
Member Author

liggitt commented Dec 3, 2019

/kind flake
/priority important-soon
/sig node

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 3, 2019
@liggitt liggitt changed the title Automated cherry pick of #85847: Deflake pod readiness e2e [1.17.1] Automated cherry pick of #85847: Deflake pod readiness e2e Dec 3, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 3, 2019
mattjmcnaughton
mattjmcnaughton approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Definitely makes sense to keep CI signal for 1.17 as healthy as possible :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2019
@mattjmcnaughton
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 4, 2019
@liggitt
Copy link
Member Author

liggitt commented Dec 5, 2019

@justaugustus if #85937 is going in, should we take this now?

@justaugustus
Copy link
Member

Release Manager approval:
/lgtm
/approve

@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Dec 5, 2019
@justaugustus justaugustus changed the title [1.17.1] Automated cherry pick of #85847: Deflake pod readiness e2e Automated cherry pick of #85847: Deflake pod readiness e2e Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4a6141e into kubernetes:release-1.17 Dec 5, 2019
@liggitt liggitt deleted the automated-cherry-pick-of-#85847-upstream-release-1.17 branch December 6, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjmcnaughton mattjmcnaughton mattjmcnaughton approved these changes

@dims dims Awaiting requested review from dims

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@justaugustus justaugustus

@mattjmcnaughton mattjmcnaughton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @mattjmcnaughton @justaugustus @k8s-ci-robot