Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service pages to v1beta3 in web ui #8611

Merged
merged 1 commit into from
May 28, 2015
Merged

Update service pages to v1beta3 in web ui #8611

merged 1 commit into from
May 28, 2015

Conversation

bcbroussard
Copy link
Contributor

@caesarxuchao
Copy link
Member

Thanks, @bcbroussard, I can't find any problem. Have you guys tested it? And how can I view the GUI?

@bcbroussard
Copy link
Contributor Author

@caesarxuchao yes we have tested all of these locally in vagrant. The webUI is built into the apiserver, so I'll goto https:///static/app/ . Ping me (bcbroussard) on the irc channel and I can go into more details.

@k8s-bot
Copy link

k8s-bot commented May 21, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain @ixdy.

@bcbroussard
Copy link
Contributor Author

@caesarxuchao can I get a LGTM status label?

@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2015
@thockin
Copy link
Member

thockin commented May 27, 2015

rebase, please

@bgrant0607
Copy link
Member

I'd like to get all of the v1beta3-related PRs ASAP, prior to the 0.18 cut. Please rebase.

@thockin
Copy link
Member

thockin commented May 27, 2015

needs rebase

@bcbroussard
Copy link
Contributor Author

@thockin rebased

@bcbroussard bcbroussard mentioned this pull request May 27, 2015
Merged
@bgrant0607
Copy link
Member

Tests failed:

Error: [$injector:nomod] Module 'kubernetesApp.components.dashboard' is not available!

@bcbroussard
Copy link
Contributor Author

@bgrant0607 This error occasionally occurs due to a race condition in the gulp build task. I verified that #8612 works and it is built with this PR as a dependency. If the #8612 build passes are you ok merging both to fix this? I'll have a fixed PR ready just in case.

Jack mentioned that his outstanding PR refactoring the build has fixed the race condition.

@bgrant0607
Copy link
Member

Restarted Travis. Not sure why Shippable didn't run.

@bcbroussard
Copy link
Contributor Author

Rebuilt and pushed an updated version to restart Shippable and Travis

@bcbroussard bcbroussard mentioned this pull request May 28, 2015
Merged
thockin added a commit that referenced this pull request May 28, 2015
@thockin
Merge pull request #8611 from bcbroussard/v1beta3-services
f53b4a1 
Update service pages to v1beta3 in web ui
@thockin thockin merged commit f53b4a1 into kubernetes:master May 28, 2015
@bcbroussard bcbroussard deleted the v1beta3-services branch May 28, 2015 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bcbroussard @caesarxuchao @k8s-bot @thockin @bgrant0607 @googlebot