Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubuntu cluster utils.sh verify-ssh-prereqs #8621

Merged
merged 1 commit into from May 27, 2015
Merged

ubuntu cluster utils.sh verify-ssh-prereqs #8621

merged 1 commit into from May 27, 2015

Conversation

MCyprien
Copy link

PR for #8559

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@resouer
Copy link
Contributor

resouer commented May 21, 2015

@MCyprien Thanks, we'd like to give it a review, but please fix your cla first :)

@k8s-bot
Copy link

k8s-bot commented May 21, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain @ixdy.

@MCyprien
Copy link
Author

ok I signed the CLA, I think

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@MCyprien
Copy link
Author

what about now my sweet googlebot? i signed it again

@dchen1107 dchen1107 self-assigned this May 22, 2015
@dchen1107
Copy link
Member

LGTM. Oncall will pick it up and merge it based on our e2e test result. We ran into some issues with our Jenkin e2e tests lately, and tried to control the merge rate a little bit.

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2015
@thockin thockin added cla: yes and removed cla: no labels May 27, 2015
thockin added a commit that referenced this pull request May 27, 2015
ubuntu cluster utils.sh verify-ssh-prereqs
@thockin thockin merged commit 16db5a9 into kubernetes:master May 27, 2015
@resouer resouer mentioned this pull request May 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants