Delete fails on notfound errors. #8628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain @ixdy. |
|
ok to test |
|
LGTM |
dchen1107
added
the
lgtm
|
rebase |
j3ffml
force-pushed
the
delete-not-found
branch
2 times, most recently
from
bfacc92
to
9e4fb14
Compare
|
Fails CI |
If deleting multiple resources, command will continue on error and report not found resources at the end.
|
Whoops, I accidentally rebased/pushed from an older repo. Rebased the correct one now. PTAL. |
thockin
added a commit
that referenced
this pull request
May 27, 2015
Delete fails on notfound errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If deleting multiple resources, command will continue on error and
report not found resources at the end. You can ignore not found errors (previous behavior) by passing
--ignore-not-found.Closes #8218