Rename 'kubectl log' to 'kubectl logs' #8634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thockin ptal |
|
LGTM, though I am not deeply familiar with kubectl infra. @jlowdermilk |
| @@ -63,7 +63,7 @@ func selectContainer(pod *api.Pod, in io.Reader, out io.Writer) string { | |||
| // NewCmdLog creates a new pod log command | |||
| func NewCmdLog(f *cmdutil.Factory, out io.Writer) *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "log [-f] [-p] POD [CONTAINER]", | |||
| Use: "logs [-f] [-p] POD [CONTAINER]", | |||
There was a problem hiding this comment.
With command renames, we've been keeping the old one as an alias (with a deprecation warning) to avoid breaking existing uses. See rollingupdate.go for an example that does this.
|
LGTM, thanks. |
j3ffml
added
the
lgtm
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain @ixdy. |
|
LGTM Please rebase it so that I can merge, sorry for the inconvenience. |
|
rebased |
|
@dchen1107 or @jlowdermilk, I've rebased on to the latest master. When you get a chance, can you please merge? Thx much. |
|
cc @saad-ali |
saad-ali
added a commit
that referenced
this pull request
May 26, 2015
Rename 'kubectl log' to 'kubectl logs'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8535