New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix kubectl apply set last applied namespace error #86474
fix kubectl apply set last applied namespace error #86474
Conversation
Hi @zhouya0. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @seans3 |
/ok-to-test |
/retest |
/test pull-kubernetes-e2e-gce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/kind bug |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, zhouya0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
@zhouya0: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…pplied_namespace fix kubectl apply set last applied namespace error Kubernetes-commit: 99715d7
What type of PR is this?
What this PR does / why we need it:
kubectl apply set-last-applied
should use resource's namespace but not given namespace. Otherwise it will use thedefault
namespace. See kubectl apply set-last-applied does not use manifest'smetadata.namespace
kubectl#787Which issue(s) this PR fixes:
Fixes #kubernetes/kubectl#787
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: