Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require client / server protocols #86646

Merged
merged 1 commit into from Jan 6, 2020
Merged

Conversation

@tedyu
Copy link
Contributor

tedyu commented Dec 26, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR addresses TODO in staging/src/k8s.io/apimachinery/pkg/util/httpstream/httpstream.go

Which issue(s) this PR fixes:
Fixes #

For subprotocol negotiation, both client and server protocol is required now.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Dec 26, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot requested a review from ncdc Dec 26, 2019
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 2, 2020

/assign

@tedyu tedyu changed the title Require client protocols Require client / server protocols Jan 3, 2020
@yutedz yutedz force-pushed the yutedz:client-protocol branch from be52262 to 9ee1310 Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added size/M and removed size/XS labels Jan 3, 2020
@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 3, 2020

@liggitt
Please take another look.

@yutedz yutedz force-pushed the yutedz:client-protocol branch from 9ee1310 to 9a25b1e Jan 3, 2020
@yutedz yutedz force-pushed the yutedz:client-protocol branch 2 times, most recently from 969e460 to c68f1b7 Jan 3, 2020
@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 5, 2020

/test pull-kubernetes-e2e-gce

1 similar comment
@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 5, 2020

/test pull-kubernetes-e2e-gce

@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 6, 2020

@ncdc
Please take another look.

@yutedz yutedz force-pushed the yutedz:client-protocol branch from e263915 to 4ead0b9 Jan 6, 2020
@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 6, 2020

@ncdc
Please take another look.

@ncdc
ncdc approved these changes Jan 6, 2020
@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented Jan 6, 2020

/lgtm

over to you @liggitt

@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented Jan 6, 2020

/lgtm cancel

waiting on test header fix

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 6, 2020
@yutedz yutedz force-pushed the yutedz:client-protocol branch from 4ead0b9 to 906adbd Jan 6, 2020
@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 6, 2020

@ncdc @liggitt
Header adjustment has been made

@ncdc

This comment has been minimized.

Copy link
Member

ncdc commented Jan 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 6, 2020
@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 6, 2020

/lgtm
/approve

should add a release note

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 6, 2020

@liggitt
Release note updated.

@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 6, 2020

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 6, 2020

/test pull-kubernetes-e2e-gce

1 similar comment
@tedyu

This comment has been minimized.

Copy link
Contributor Author

tedyu commented Jan 6, 2020

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 19ecd69 into kubernetes:master Jan 6, 2020
15 checks passed
15 checks passed
cla/linuxfoundation yutedz authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.