Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require client / server protocols #86646

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Require client / server protocols #86646

merged 1 commit into from
Jan 6, 2020

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Dec 26, 2019 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR addresses TODO in staging/src/k8s.io/apimachinery/pkg/util/httpstream/httpstream.go

Which issue(s) this PR fixes:
Fixes #

For subprotocol negotiation, both client and server protocol is required now.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 26, 2019
@tedyu
Copy link
Contributor Author

tedyu commented Dec 26, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 26, 2019
@tedyu tedyu mentioned this pull request Jan 2, 2020
Closed
@liggitt
Copy link
Member

liggitt commented Jan 2, 2020

/assign

@tedyu tedyu changed the title Require client protocols Require client / server protocols Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2020
@tedyu
Copy link
Contributor Author

tedyu commented Jan 3, 2020

@liggitt
Please take another look.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jan 3, 2020
@yutedz yutedz force-pushed the client-protocol branch 2 times, most recently from 969e460 to c68f1b7 Compare January 4, 2020 22:37
@tedyu
Copy link
Contributor Author

tedyu commented Jan 5, 2020

/test pull-kubernetes-integration

@tedyu
Copy link
Contributor Author

tedyu commented Jan 5, 2020

/test pull-kubernetes-e2e-gce

1 similar comment
@tedyu
Copy link
Contributor Author

tedyu commented Jan 5, 2020

/test pull-kubernetes-e2e-gce

@tedyu
Copy link
Contributor Author

tedyu commented Jan 6, 2020

@ncdc
Please take another look.

@tedyu
Copy link
Contributor Author

tedyu commented Jan 6, 2020

@ncdc
Please take another look.

@ncdc
Copy link
Member

ncdc commented Jan 6, 2020

/lgtm

over to you @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@ncdc
Copy link
Member

ncdc commented Jan 6, 2020

/lgtm cancel

waiting on test header fix

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@tedyu
Copy link
Contributor Author

tedyu commented Jan 6, 2020

@ncdc @liggitt
Header adjustment has been made

@ncdc
Copy link
Member

ncdc commented Jan 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@liggitt
Copy link
Member

liggitt commented Jan 6, 2020

/lgtm
/approve

should add a release note

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tedyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 6, 2020
@tedyu
Copy link
Contributor Author

tedyu commented Jan 6, 2020

@liggitt
Release note updated.

@tedyu
Copy link
Contributor Author

tedyu commented Jan 6, 2020

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@tedyu
Copy link
Contributor Author

tedyu commented Jan 6, 2020

/test pull-kubernetes-e2e-gce

1 similar comment
@tedyu
Copy link
Contributor Author

tedyu commented Jan 6, 2020

/test pull-kubernetes-e2e-gce

@k8s-ci-robot k8s-ci-robot merged commit 19ecd69 into kubernetes:master Jan 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc approved these changes

@neolit123 neolit123 neolit123 left review comments

@liggitt liggitt liggitt left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@ncdc ncdc

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tedyu @liggitt @ncdc @k8s-ci-robot @neolit123 @yutedz