-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Harmless] K8petstore shell update, separated from the larger PR #8678
Conversation
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain @ixdy. |
@chuckbutler has tested this iirc. |
Fixing example ok for 1.0. Assigning reviewer. |
@jayunit100 sounds good to me. I haven't had a chance to circle back to this yet w/ any of the modifications, but should have some time on Thursday to give it all a good look/run-through for our action(s) usecase. Thanks! |
LGTM with whitespace fix on like 23{1,2,3} |
Also, cleaned up whitespace inconsistencies.
yup, okay fixed the whitespaces needed some WS cleanups, done ! thanks @eparis |
if this LGTeparis then it LGTM. |
what are the shippable failures? |
I chose to ignore shippable because you can't see the failures without giving them excessive github permissions. The travis failures appear to be a failure during race checking. That can't be related to this PR. |
both 1.3 and 1.4
|
[Harmless] K8petstore shell update, separated from the larger PR
Here is a quick update to k8petstore. Ive separated it from the other PR because people are now using it and this will be an easy review for folks (it only touches one file, in examples) :)